[Gluster-devel] Change in exit codes of #gluster volume heal command

Vikhyat Umrao vumrao at redhat.com
Thu May 29 12:41:11 UTC 2014


On 05/28/2014 10:58 PM, James wrote:
> On Wed, May 28, 2014 at 1:10 PM, Jeff Darcy <jdarcy at redhat.com> wrote:
>>> In addition, I would recommend considering using --xml and that
>>> picking out the field you want to look at with a quick xml parser, and
>>> then going with that directly. More stable than watching for a
>>> specific return code.
>> Parsing XML to get one bit of information doesn't seem like a great
>> idea.  If the script needs exact counts then sure, parse away, but if
>> all it needs to know is whether any are non-zero then what's wrong
>> with having that reflected in the exit code?  That's far easier for a
>> script to interpret, and there's plenty of precedent for using exit
>> codes this way.
>
> Parsing an exit code for 2 vs. 4 instead of 2 vs. zero and then doing
> something based on that IMO is a bit flimsy.
> I agree with checking if a code is non-zero is highly useful.
     Thanks every one for your inputs.
     I have tested #gluster volume heal command  with --xml option and 
it does not support it.
     Like #gluster volume --xml status or info command.

     Real purpose behind having different exit codes is same as above 
got discussed.

     Regards,
     Vikhyat


More information about the Gluster-devel mailing list