[Gluster-devel] regarding special treatment of ENOTSUP for setxattr

[Pranith Kumar Karampuri]

----- Original Message -----
> From: "Raghavendra Gowdappa" <rgowdapp at redhat.com>
> To: "Pranith Kumar Karampuri" <pkarampu at redhat.com>
> Cc: "Vijay Bellur" <vbellur at redhat.com>, gluster-devel at gluster.org, "Anand Avati" <aavati at redhat.com>
> Sent: Wednesday, May 7, 2014 3:42:16 PM
> Subject: Re: [Gluster-devel] regarding special treatment of ENOTSUP for setxattr
> 
> I think with "repetitive log message suppression" patch being merged, we
> don't really need gf_log_occasionally (except if they are logged in DEBUG or
> TRACE levels).

That definitely helps. But still, setxattr calls are not supposed to fail with ENOTSUP on FS where we support gluster. If there are special keys which fail with ENOTSUPP, we can conditionally log setxattr failures only when the key is something new?

Pranith

> 
> ----- Original Message -----
> > From: "Pranith Kumar Karampuri" <pkarampu at redhat.com>
> > To: "Vijay Bellur" <vbellur at redhat.com>
> > Cc: gluster-devel at gluster.org, "Anand Avati" <aavati at redhat.com>
> > Sent: Wednesday, 7 May, 2014 3:12:10 PM
> > Subject: Re: [Gluster-devel] regarding special treatment of ENOTSUP for
> > setxattr
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Vijay Bellur" <vbellur at redhat.com>
> > > To: "Pranith Kumar Karampuri" <pkarampu at redhat.com>, "Anand Avati"
> > > <aavati at redhat.com>
> > > Cc: gluster-devel at gluster.org
> > > Sent: Tuesday, May 6, 2014 7:16:12 PM
> > > Subject: Re: [Gluster-devel] regarding special treatment of ENOTSUP for
> > > setxattr
> > > 
> > > On 05/06/2014 01:07 PM, Pranith Kumar Karampuri wrote:
> > > > hi,
> > > >    Why is there occasional logging for ENOTSUP errno when setxattr
> > > >    fails?
> > > >
> > > 
> > > In the absence of occasional logging, the log files would be flooded
> > > with this message every time there is a setxattr() call.
> > 
> > How to know which keys are failing setxattr with ENOTSUPP if it is not
> > logged
> > when the key keeps changing?
> > 
> > Pranith
> > > 
> > > -Vijay
> > > 
> > > 
> > _______________________________________________
> > Gluster-devel mailing list
> > Gluster-devel at gluster.org
> > http://supercolony.gluster.org/mailman/listinfo/gluster-devel
> > 
>