[Gluster-devel] pkg-config needed again by autogen.sh

[Justin Clift]

On 05/05/2014, at 2:28 PM, Kaleb S. KEITHLEY wrote:
> On 05/04/2014 01:26 PM, Justin Clift wrote:
<snip>
>>> Looks like we've started using PKG_CHECK_MODULES again in git master:
>>> 
>>>  $ grep -ri "PKG_CHECK_MODULES" *
>>>  api/examples/configure.ac:PKG_CHECK_MODULES([GLFS], [glusterfs-api >= 3])
>>>  configure.ac:  PKG_CHECK_MODULES([GLIB], [glib-2.0],
>>>  configure.ac:PKG_CHECK_MODULES([ZLIB], [zlib >= 1.2.0],
>>> ...
>>> You had good insight about this last time:
>>> 
>>>  https://bugzilla.redhat.com/show_bug.cgi?id=921817#c4
>>> 
>>> What's the right way to proceed here? :)
> 
> I'm guessing this is related to the new MacOS X port.
> 
> As I recall, using the autoconf bits seemed to be intrinsically more portable than pkg-config bits, especially on other platforms like MacOS and Solaris.
> 
> Give http://review.gluster.org/7674 a try and see if that works better for you.
> 
> The glib2 autoconf bits look like they'll try to do something sane if there are no pkg-config bits. The zlib bits maybe not so much — that part might need more work.


Doesn't seem like a go-er.  Now when running ./autogen.sh
(without pkg-config installed) it gives:

  $ ./autogen.sh 

  ... GlusterFS autogen ...

  Generate gf-error-codes.h ...
  gf-error-codes.h -> libglusterfs/src/gf-error-codes.h
  Running aclocal...
  configure.ac:453: warning: macro `AM_PATH_GLIB_2_0' not found in library
  Running autoheader...
  Running glibtoolize...
  Running autoconf...
  configure.ac:318: error: possibly undefined macro: AC_DEFINE
        If this token and others are legitimate, please use m4_pattern_allow.
        See the Autoconf documentation.
  configure.ac:453: error: possibly undefined macro: AM_PATH_GLIB_2_0
  Running automake...
  configure.ac:205: installing `./config.sub'
  configure.ac:16: installing `./missing'
  configure.ac:16: installing `./install-sh'
  configure.ac:205: installing `./config.guess'
  api/examples/Makefile.am: installing `./depcomp'
  api/examples/Makefile.am:10: installing `./py-compile'
  Running autogen.sh in argp-standalone ...
  configure.ac:10: installing `./missing'
  configure.ac:10: installing `./install-sh'
  Makefile.am: installing `./depcomp'

  Please proceed with configuring, compiling, and installing.
  $

The AC_DEFINE warning is from pkg-config not being present.  The
AM_PATH_GLIB_2_0 ones are new, added by your patch. ;)

As extra data points, automake on OSX 10.7.5 is version 1.1.0.  autoconf
is version 2.61.

Regards and best wishes,

Justin Clift

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift