[Gluster-devel] pkg-config needed again by autogen.sh

[Justin Clift]

Hi Vijay,

Looks like we've started using PKG_CHECK_MODULES again in git master:

  $ grep -ri "PKG_CHECK_MODULES" *
  api/examples/configure.ac:PKG_CHECK_MODULES([GLFS], [glusterfs-api >= 3])
  configure.ac:  PKG_CHECK_MODULES([GLIB], [glib-2.0],
  configure.ac:PKG_CHECK_MODULES([ZLIB], [zlib >= 1.2.0],

Which leads to this again when pkg-config isn't present:

  $ ./autogen.sh 

  ... GlusterFS autogen ...

  Generate gf-error-codes.h ...
  gf-error-codes.h -> libglusterfs/src/gf-error-codes.h
  Running aclocal...
  Running autoheader...
  Running glibtoolize...
  Running autoconf...
  configure.ac:316: error: possibly undefined macro: AC_DEFINE
        If this token and others are legitimate, please use m4_pattern_allow.
        See the Autoconf documentation.
  Running automake...
  configure.ac:203: installing `./config.sub'
  configure.ac:16: installing `./missing'
  configure.ac:16: installing `./install-sh'
  configure.ac:203: installing `./config.guess'
  api/examples/Makefile.am: installing `./depcomp'
  api/examples/Makefile.am:10: installing `./py-compile'
  Running autogen.sh in argp-standalone ...
  configure.ac:10: installing `./missing'
  configure.ac:10: installing `./install-sh'
  Makefile.am: installing `./depcomp'

  Please proceed with configuring, compiling, and installing.
  $

You had good insight about this last time:

  https://bugzilla.redhat.com/show_bug.cgi?id=921817#c4

What's the right way to proceed here? :)

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift