[Gluster-devel] Need clarification regarding the "force" option for snapshot delete.

[Sachin Pandit]

Hi all,

We had some concern regarding the snapshot delete "force" option,
That is the reason why we thought of getting advice from everyone out here.

Currently when we give "gluster snapshot delete <snapname>", It gives a notification
saying that "mentioned snapshot will be deleted, Do you still want to continue (y/n)?".
As soon as he presses "y" it will delete the snapshot.

Our new proposal is, When a user issues snapshot delete command "without force"
then the user should be given a notification saying to use "force" option to
delete the snap.
When snapshot delete command is issued with "force" option then the user should
be given a notification saying "Mentioned snapshot will be deleted, Do you still
want to continue (y/n)".

The reason we thought of bringing this up is because we have planned to introduce
a command "gluster snapshot delete all" which deletes all the snapshot in a system,
and "gluster snapshot delete volume <volname>" which deletes all the snapshots in 
the mentioned volume. If user accidentally issues any one of the above mentioned
command and press "y" then he might lose few or more snapshot present in volume/system.
(Thinking it will ask for notification for each delete).

Do you think notification would be more than enough, or do we need to introduce
a "force" option ?

------------------------------------------------------------------------------
Current procedure:
------------------

[root at snapshot-24 glusterfs]# gluster snapshot delete snap1
Deleting snap will erase all the information about the snap.
Do you still want to continue? (y/n)


Proposed procedure:
-------------------

[root at snapshot-24 glusterfs]# gluster snapshot delete snap1
Please use the force option to delete the snap.

[root at snapshot-24 glusterfs]# gluster snapshot delete snap1 force
Deleting snap will erase all the information about the snap.
Do you still want to continue? (y/n)
------------------------------------------------------------------------------

We are looking forward for the feedback on this.

Thanks,
Sachin Pandit.