[Gluster-devel] Reviewing patches early

James purpleidea at gmail.com
Thu Jun 26 02:12:27 UTC 2014


On Wed, Jun 25, 2014 at 9:35 PM, Jeff Darcy <jdarcy at redhat.com> wrote:
>> While I agree with everything you said. Complaining about tabs/spaces
>> should be done by a script. Something like
>> http://review.gluster.com/#/c/5404
>> Some one who knows perl should help us with rebasing it and getting it in
>
> Agreed.  If there are standards that are going to be enforced even if
> they're counterproductive (and I think several aspects of our coding
> standard fit that description) then we should at least enforce them
> quickly via a checkin script instead of making people run regressions
> twice.


I too agree that using spaces instead of tabs is counterproductive. ;)

It could be worse though: http://www.emacswiki.org/emacs/TabsSpacesBoth


More information about the Gluster-devel mailing list