[Gluster-devel] 3.5.1-beta2 Problems with suid and sgid bits on directories

[Anders Blomdell]

On 2014-06-17 18:47, Anders Blomdell wrote:
> On 2014-06-17 17:49, Shyamsundar Ranganathan wrote:
>> You maybe looking at the problem being fixed here, [1].
>>
>> On a lookup attribute mismatch was not being healed across
>> directories, and this patch attempts to address the same. Currently
>> the version of the patch does not heal the S_ISUID and S_ISGID bits,
>> which is work in progress (but easy enough to incorporate and test
>> based on the patch at [1]).
> Thanks, will look into it tomorrow.
> 
>> On a separate note, add-brick just adds a brick to the cluster, the
>> lookup is where the heal (or creation of the directory across all sub
>> volumes in DHT xlator) is being done.
> Thanks for the clarification (I guess that a rebalance would trigger it as well?)
Attached slightly modified version of patch [1] seems to work correctly after a rebalance
that is allowed to run to completion on its own, if directories are traversed during rebalance, 
some 07777 dirs show spurious 01777, 00000 and sometimes ends up with the wrong permission.

Continuing debug tomorrow...
> 
>>
>> Shyam
>>
>> [1] http://review.gluster.org/#/c/6983/
>>
>> ----- Original Message -----
>>> From: "Anders Blomdell" <anders.blomdell at control.lth.se> To:
>>> "Gluster Devel" <gluster-devel at gluster.org> Sent: Tuesday, June 17,
>>> 2014 10:53:52 AM Subject: [Gluster-devel] 3.5.1-beta2 Problems with
>>> suid and sgid bits on	directories
>>>
>> With a glusterfs-3.5.1-0.3.beta2.fc20.x86_64 with a reverted 
>> 3dc56cbd16b1074d7ca1a4fe4c5bf44400eb63ff (due to local lack of IPv4 
>> addresses), I get weird behavior if I:
>>
>> 1. Create a directory with suid/sgid/sticky bit set
>> (/mnt/gluster/test) 2. Make a subdirectory of #1
>> (/mnt/gluster/test/dir1) 3. Do an add-brick
>>
>> Before add-brick
>>
>> 755 /mnt/gluster 7775 /mnt/gluster/test 2755 /mnt/gluster/test/dir1
>>
>> After add-brick
>>
>> 755 /mnt/gluster 1775 /mnt/gluster/test 755 /mnt/gluster/test/dir1
>>
>> On the server it looks like this:
>>
>> 7775 /data/disk1/gluster/test 2755 /data/disk1/gluster/test/dir1 1775
>> /data/disk2/gluster/test 755 /data/disk2/gluster/test/dir1
>>
>> Filed as bug:
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1110262
>>
>> If somebody can point me to where the logic of add-brick is placed, I
>> can give it a shot (a find/grep on mkdir didn't immediately point me
>> to the right place).
>>
>>
> /Anders
> 
/Anders

-- 
Anders Blomdell                  Email: anders.blomdell at control.lth.se
Department of Automatic Control
Lund University                  Phone:    +46 46 222 4625
P.O. Box 118                     Fax:      +46 46 138118
SE-221 00 Lund, Sweden

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gluster-sgid.patch
Type: text/x-patch
Size: 3803 bytes
Desc: not available
URL: <http://supercolony.gluster.org/pipermail/gluster-devel/attachments/20140618/989cb829/attachment.bin>