[Gluster-devel] quota tests and usage of sleep

[Pranith Kumar Karampuri]

On 06/17/2014 11:14 AM, Varun Shastry wrote:
>
>>>     > ----- Original Message -----
>>>     >> hi,
>>>     >>       Could you guys remove 'sleep' for quota tests authored
>>>     by you guys
>>>     >> if it can be done. They are leading to spurious failures.
>>>
>
> I don't get how sleep can cause the failures. But for script 
> bug-1087198.t  in my name, it is part of the testing. I can reduce it 
> to a smaller value but we need to have the test which waits for a 
> small amount of time.
Sleeps are added to make sure a certain condition is met in that time. 
Sometimes what happens is that the condition could take longer to meet 
causing spurious failure. So we are going through the tests and 
eliminating 'sleeps' that is not required. Or use better expect_within 
statement to make sure the condition is met using explicit tests.

Pranith
>
> - Varun Shastry
>
>>>     >> I will be sending out a patch removing 'sleep' in other tests.
>>>     >>
>>>     >> Pranith
>>>     >>
>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://supercolony.gluster.org/pipermail/gluster-devel/attachments/20140617/f82e9a2f/attachment-0001.html>