[Gluster-devel] Cmockery2 in GlusterFS

[Niels de Vos]

On Fri, Jul 18, 2014 at 02:52:18PM -0400, Luis Pabón wrote:
> Hi all,
>     A few months ago, the unit test framework based on cmockery2 was
> in the repo for a little while, then removed while we improved the
> packaging method.  Now support for cmockery2 (
> http://review.gluster.org/#/c/7538/ ) has been merged into the repo
> again.  This will most likely require you to install cmockery2 on
> your development systems by doing the following:
> 
> * Fedora/EPEL:
> $ sudo yum -y install cmockery2-devel
> 
> * All other systems please visit the following page: https://github.com/lpabon/cmockery2/blob/master/doc/usage.md#installation
> 
> Here is also some information about Cmockery2 and how to use it:
> 
> * Introduction to Unit Tests in C Presentation:
> http://slides-lpabon.rhcloud.com/feb24_glusterfs_unittest.html#/
> * Cmockery2 Usage Guide:
> https://github.com/lpabon/cmockery2/blob/master/doc/usage.md
> * Using Cmockery2 with GlusterFS: https://github.com/gluster/glusterfs/blob/master/doc/hacker-guide/en-US/markdown/unittest.md
> 
> 
> When starting out writing unit tests, I would suggest writing unit
> tests for non-xlator interface files when you start.  Once you feel
> more comfortable writing unit tests, then move to writing them for
> the xlators interface files.

Awesome, many thanks! I'd like to add some unittests for the RPC and NFS
layer. Several functions (like ip-address/netmask matching for ACLs) 
look very suitable.

Did you have any particular functions in mind that you would like to see 
unittests for? If so, maybe you can file some bugs for the different 
tests so that we won't forget about it? Depending on the tests, these 
bugs may get the EasyFix keyword if there is a clear description and 
some pointers to examples.

Thanks,
Niels