[Gluster-devel] libgfapi version format change affecting QEMU-GlusterFS

Vijay Bellur vbellur at redhat.com
Sat Jan 25 10:46:40 UTC 2014


On 01/25/2014 04:13 PM, Bharata B Rao wrote:
> On Sat, Jan 25, 2014 at 4:04 PM, Harshavardhana
> <harsha at harshavardhana.net <mailto:harsha at harshavardhana.net>> wrote:
>
>      > "In essence, every time you make a change to the library and
>      >     release it, the C:R:A should change. A new library should start
>      >     with 0:0:0. Each time you change the public interface
>      >     (i.e., your installed header files), you should increment the
>      >     CURRENT number."
>      >
>      > So the version which was 3 became 5 when discard API was added
>     and became 6
>      > when zerofill was added. As per the above description, API
>     addition will
>      > result in a change to the installed header(glfs.h) and hence
>     warrants a
>      > change in CURRENT number ? Should you have changed the version to
>     6.0.0
>      > instead of 0.0.6 ?
>      >
>
>     You are in-fact correct here - i didn't know about the API changes
>     with 3, 5, 6.
>     I will send out a patch regarding that. Basis on bumping the 'AGE' was
>     wrong - since
>     i just assumed public interface didn't change.
>
>
> Not for this specific change, but may be it's time to add a test case
> into gluster to test QEMU requirements. The last effort in that
> direction was made here:
> http://lists.nongnu.org/archive/html/gluster-devel/2013-02/msg00014.html
>

Yes, it would be good to revive this. For some obvious and non-obvious 
reasons, we have not got this working. I will mail you and Poornima 
off-list to see how we can get this rolling.

Thanks,
Vijay





More information about the Gluster-devel mailing list