[Gluster-devel] one more unchecked malloc in 3.5.0beta3

[Emmanuel Dreyfus]

Another crash on a brick: trans is NULL in rpcsvc_submit_generic().
I pushed ulimit for total memeory and heap, hence I suspect there is a 
huge memory leak somewhere. I hope it will not make it to the release,
otherwise it will be just unusable for me.

#0  0xbb7dd6d0 in strcpy () from /lib/libc.so.12
#1  0xbbb630e9 in _gf_log (domain=0xbbbcf2fe "rpc-service", 
    file=0xbbbcfd60 "rpcsvc.c", function=0xbbbd0433 "rpcsvc_submit_generic", 
    line=1206, level=GF_LOG_ERROR, 
    fmt=0xbbbcf85c "failed to submit message (XID: 0x%x, Program: %s, ProgVers: %d, Proc: %d) to rpc-transport (%s)") at logging.c:874
#2  0xbbbc5278 in rpcsvc_submit_generic (req=0xb9204570, proghdr=0x1d7fef04, 
    hdrcount=1, payload=0x0, payloadcount=0, iobref=0x81fe098) at rpcsvc.c:1208
#3  0xb9e15b63 in server_submit_reply (frame=0xba702f38, req=0xb9204570, 
    arg=0x1d7ff018, payload=0x0, payloadcount=0, iobref=0x81fe098, 
    xdrproc=0xbbbdb99c <xdr_gfs3_create_rsp>) at server.c:177
#4  0xb9e2f7d5 in server_create_cbk (frame=0xba702f38, cookie=0xbb58b258, 
    this=0xb9ff4018, op_ret=0, op_errno=0, fd=0xb809e388, inode=0xb8173ca8, 
    stbuf=0x1d7ff5c0, preparent=0x1d7ff558, postparent=0x1d7ff4f0, 
    xdata=0x81fc328) at server-rpc-fops.c:1627
#5  0xb9e4fdbf in io_stats_create_cbk (frame=0xbb58b258, cookie=0xbb58be28, 
    this=0xb9ff2018, op_ret=0, op_errno=0, fd=0xb809e388, inode=0xb8173ca8, 
    buf=0x1d7ff5c0, preparent=0x1d7ff558, postparent=0x1d7ff4f0, 
    xdata=0x81fc328) at io-stats.c:1234
#6  0xb9e79354 in marker_create_cbk (frame=0xbb58be28, cookie=0xbb58bc68, 
    this=0xb9ff0018, op_ret=0, op_errno=0, fd=0xb809e388, inode=0xb8173ca8, 
    buf=0x1d7ff5c0, preparent=0x1d7ff558, postparent=0x1d7ff4f0, 
    xdata=0x81fc328) at marker.c:651
#7  0xb9e9786d in iot_create_cbk (frame=0xbb58bc68, cookie=0xbb58bb88, 
    this=0xb9fee018, op_ret=0, op_errno=0, fd=0xb809e388, inode=0xb8173ca8, 
    stbuf=0x1d7ff5c0, preparent=0x1d7ff558, postparent=0x1d7ff4f0, 
    xdata=0x81fc328) at io-threads.c:910
#8  0xbb60a66b in pl_create_cbk (frame=0xbb58bb88, cookie=0xbb58c598, 
    this=0xb9fed018, op_ret=0, op_errno=0, fd=0xb809e388, inode=0xb8173ca8, 
    buf=0x1d7ff5c0, preparent=0x1d7ff558, postparent=0x1d7ff4f0, 
    xdata=0x81fc328) at posix.c:1056
#9  0xbb620a82 in posix_acl_create_cbk (frame=0xbb58c598, cookie=0xbb58c058, 
    this=0xb9fde018, op_ret=0, op_errno=0, fd=0xb809e388, inode=0xb8173ca8, 
    buf=0x1d7ff5c0, preparent=0x1d7ff558, postparent=0x1d7ff4f0, 
    xdata=0x81fc328) at posix-acl.c:1225
#10 0xbb6287a8 in changelog_create_cbk (frame=0xbb58c058, cookie=0xbb58b808, 
    this=0xb9fdd018, op_ret=0, op_errno=0, fd=0xb809e388, inode=0xb8173ca8, 
    buf=0x1d7ff5c0, preparent=0x1d7ff558, postparent=0x1d7ff4f0, 
    xdata=0x81fc328) at changelog.c:530
#11 0xbb63bf1a in posix_create (frame=0xbb58b808, this=0xb9fdc018, 
    loc=0xba109968, flags=1538, mode=33152, umask=0, fd=0xb809e388, 
    xdata=0x81fc328) at posix.c:2238
#12 0xbb62b474 in changelog_create (frame=0xbb58c058, this=0xb9fdd018, 
    loc=0xba109968, flags=1538, mode=33152, umask=0, fd=0xb809e388, 
    xdata=0x81fc328) at changelog.c:586
#13 0xbb61fc55 in posix_acl_create (frame=0xbb58c598, this=0xb9fde018,    loc=0xba109968, flags=1538, mode=33152, umask=0, fd=0xb809e388, 
    xdata=0x81fc328) at posix-acl.c:1245
#14 0xbb607d2c in pl_create (frame=0xbb58bb88, this=0xb9fed018, 
    loc=0xba109968, flags=1538, mode=33152, umask=0, fd=0xb809e388, 
    xdata=0x81fc328) at posix.c:1068
#15 0xb9e9b9f1 in iot_create_wrapper (frame=0xbb58bc68, this=0xb9fee018, 
    loc=0xba109968, flags=1538, mode=33152, umask=0, fd=0xb809e388, 
    xdata=0x81fc328) at io-threads.c:921
#16 0xbbb81c0d in call_resume_wind (stub=0xba109948) at call-stub.c:2528
#17 call_resume (stub=0xba109948) at call-stub.c:2841
#18 0xb9e9cf8e in iot_worker (data=0xba0f4058) at io-threads.c:191
#19 0xbb9c04ea in ?? () from /usr/lib/libpthread.so.1
#20 0xbb76dea0 in ___lwp_park50 () from /lib/libc.so.12
#21 0x1d600000 in ?? ()
#22 0xbbb88144 in __glusterfs_this_location () at globals.c:119
#23 0xbbb88144 in __glusterfs_this_location () at globals.c:119
#24 0xbbb62d04 in _gf_log (domain=0x0, file=0x0, function=0x0, line=0, 
    level=GF_LOG_NONE, fmt=0x0) at logging.c:757
#25 0x00000000 in ?? ()

(gdb) frame 2
#2  0xbbbc5278 in rpcsvc_submit_generic (req=0xb9204570, proghdr=0x1d7fef04, 
    hdrcount=1, payload=0x0, payloadcount=0, iobref=0x81fe098) at rpcsvc.c:1208
1208                    gf_log (GF_RPCSVC, GF_LOG_TRACE,
(gdb) list
1203                            "rpc-transport (%s)", req->xid,
1204                            req->prog ? req->prog->progname : "(not matched)",
1205                            req->prog ? req->prog->progver : 0,
1206                            req->procnum, trans->name);
1207            } else {
1208                    gf_log (GF_RPCSVC, GF_LOG_TRACE,
1209                            "submitted reply for rpc-message (XID: 0x%x, "
1210                            "Program: %s, ProgVers: %d, Proc: %d) to rpc-transport "
1211                            "(%s)", req->xid, req->prog ? req->prog->progname: "-",
1212                            req->prog ? req->prog->progver : 0,
(gdb) print trans
$5 = (rpc_transport_t *) 0x0


-- 
Emmanuel Dreyfus
manu at netbsd.org