[Gluster-devel] Inclusion of /var/log/messages in log archive in regression.sh

[Niels de Vos]

On Sat, Dec 13, 2014 at 10:54:22AM +0530, Humble Devassy Chirammal wrote:
> >
> And I think that including
> everything from /var/log/messages is too much.
> >
> 
> only if regression fails we capture messages file, I dont think its a big
> overhead.
> 
> > But, I also did not check
> how big /var/log/messages is on a Jenkins slave
> >
> Capturing last/active messages file should be fine.

Works for me, get it in first and if it gets too big, we can tune it
later.

Thanks,
Niels


> 
> --Humble
> 
> 
> On Thu, Dec 11, 2014 at 4:25 PM, Niels de Vos <ndevos at redhat.com> wrote:
> >
> > On Thu, Dec 11, 2014 at 03:45:28PM +0530, Humble Devassy Chirammal wrote:
> > > >
> > >
> > > I suggest to use 'logger -s' to add a marker that a regression test has
> > > been started in /var/log/messages, and only copy the contents from after
> > > the last marker into the archive
> > > >
> > >
> > > I doubt we need a marker, because its 'not' always we need to look at
> > > 'messages' file to see  whether its a  system specific issue.
> >
> > But how many lines should get gathered? And I think that including
> > everything from /var/log/messages is too much. But, I also did not check
> > how big /var/log/messages is on a Jenkins slave...
> >
> > Niels
> >
> > >
> > > --Humble
> > >
> > >
> > > On Thu, Dec 11, 2014 at 3:38 PM, Niels de Vos <ndevos at redhat.com> wrote:
> > >
> > > > On Thu, Dec 11, 2014 at 11:05:21AM +0530, Humble Devassy Chirammal
> > wrote:
> > > > > Hi Atin,
> > > > >
> > > > > Have a check at current version of regression.sh here:
> > > > >
> > > > >
> > > >
> > https://forge.gluster.org/gluster-patch-acceptance-tests/gluster-patch-acceptance-tests/blobs/master/regression.sh
> > > > >
> > > > > It should be a small patch near to line 109.
> > > >
> > > > I suggest to use 'logger -s' to add a marker that a regression test has
> > > > been started in /var/log/messages, and only copy the contents from
> > after
> > > > the last marker into the archive.
> > > >
> > > > Would that make sense?
> > > >
> > > > Thanks,
> > > > Niels
> > > >
> > > > >
> > > > > --Humble
> > > > >
> > > > > --Humble
> > > > >
> > > > >
> > > > > On Thu, Dec 11, 2014 at 9:32 AM, Atin Mukherjee <amukherj at redhat.com
> > >
> > > > wrote:
> > > > >
> > > > > > Hi Justin,
> > > > > >
> > > > > > The current regression.sh code doesn't capture /var/log/messages
> > which
> > > > > > means whether the system ran out of memory or not can not be
> > justified
> > > > > > looking at the the log archive. I strongly believe we should
> > capture
> > > > > > this message as part of archiving the log.
> > > > > >
> > > > > > Would you be able to do this change and apply it in Rackspace?
> > > > > >
> > > > > > ~Atin
> > > > > > _______________________________________________
> > > > > > Gluster-devel mailing list
> > > > > > Gluster-devel at gluster.org
> > > > > > http://supercolony.gluster.org/mailman/listinfo/gluster-devel
> > > > > >
> > > >
> > > > > _______________________________________________
> > > > > Gluster-devel mailing list
> > > > > Gluster-devel at gluster.org
> > > > > http://supercolony.gluster.org/mailman/listinfo/gluster-devel
> > > >
> > > >
> >