[Gluster-devel] glusterfs-3.4.1 bug report

[David Binderman]

Hello there,

I just ran the static analysis tool "cppcheck" over the source
code of glusterfs-3.4.1

It said many things, including

1.

> dict.c:916:2: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

    if ((SHRT_MAX> value) || (SHRT_MIN < value)) {

Maybe something like

    if ((SHRT_MAX < value) || (SHRT_MIN> value)) {

was intended.

2.

> dict.c:948:2: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Duplicate.

Regards

David Binderman