[Gluster-devel] Fwd: New Defects reported by Coverity Scan for GlusterFS

[Vijay Bellur]

Hi All,

GlusterFS is now part of Coverity's scan program:

https://scan.coverity.com/projects/987

If you are interested in becoming a member of the project to set right 
false positives and provide modeling files, please let me know.

We have more than 600 issues to track. Your help in identifying false 
positives or actually addressing the issues by sending patches will be 
very welcome. I plan to submit weekly tarballs to keep our defect 
density in check.

Below is the defect report on GlusterFS 3.5qa1. Most of these seem to be 
coming from our recent activity on bd, zerofill and nfs.

Mohan, Santosh: Can you please look into these issues?

Thanks,
Vijay


-------- Original Message --------
Subject: New Defects reported by Coverity Scan for GlusterFS
Date: Thu, 14 Nov 2013 22:57:44 -0800
From: scan-admin at coverity.com


Hi,


Please find the latest report on new defect(s) introduced to GlusterFS 
found with Coverity Scan.

Defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)


** CID 1128902:  Logically dead code  (DEADCODE)
/home/vijay/workspace/sep10/glusterfs.git/xlators/protocol/client/src/client.c: 
2055 in client_zerofill()

** CID 1128906:  Explicit null dereferenced  (FORWARD_NULL)
/home/vijay/workspace/sep10/glusterfs.git/xlators/mgmt/glusterd/src/glusterd-utils.c: 
6455 in glusterd_check_topology_identical()

** CID 1128905:  Null pointer dereference  (FORWARD_NULL)
/home/vijay/workspace/sep10/glusterfs.git/xlators/storage/bd/src/bd.c: 
2331 in init()
/home/vijay/workspace/sep10/glusterfs.git/xlators/storage/bd/src/bd.c: 
2331 in init()

** CID 1128904:  Dereference after null check  (FORWARD_NULL)
/home/vijay/workspace/sep10/glusterfs.git/xlators/protocol/client/src/client-rpc-fops.c: 
6084 in client3_3_zerofill()

** CID 1128903:  Dereference after null check  (FORWARD_NULL)
/home/vijay/workspace/sep10/glusterfs.git/xlators/cluster/stripe/src/stripe.c: 
4169 in stripe_zerofill_cbk()

** CID 1128901:  Copy-paste error  (COPY_PASTE_ERROR)
/home/vijay/workspace/sep10/glusterfs.git/xlators/storage/bd/src/bd.c: 
1103 in bd_offload_setx_cbk()

** CID 1128900:  Unchecked return value from library  (CHECKED_RETURN)
/home/vijay/workspace/sep10/glusterfs.git/xlators/storage/posix/src/posix.c: 
689 in _posix_do_zerofill()




________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan.coverity.com

To unsubscribe from the email notification for new defects, 
http://scan5.coverity.com/cgi-bin/unsubscribe.py