[Gluster-devel] [PATCH 3/3 v3] vfs_glusterfs: Samba VFS module for glusterfs

[Andrew Bartlett]

On Mon, 2013-05-20 at 03:11 -0400, Anand Avati wrote:
> Implement a Samba VFS plugin for glusterfs based on gluster's gfapi.
> This is a "bottom" vfs plugin (not something to be stacked on top of
> another module), and translates (most) calls into closest actions
> on gfapi.

Thanks for getting back to us.

The comment I have is however still around the realloc stuff.  Is
talloc_realloc() so slow that there is such value in having the code
realloc 1024 or 16 more entries than are required?

It would seem clearer if we just allocated exactly the array size
needed.   That would also allow bounds checkers like valgrind to
correctly know the 'real' allocated size. 

It just smells to me like premature optimisation, and means you have to
do the partial array memset() which always makes me nervous. 

That said, this isn't an objection, just an observation.   

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org