[Gluster-devel] Fwd: Change in glusterfs[master]: config: better (i.e. more portable) test for libxml2

[John Mark Walker]

Please review and comment.

-------- Original Message --------
Subject: Change in glusterfs[master]: config: better (i.e. more portable) test for libxml2
From: "Kaleb KEITHLEY (Code Review)" <root at dev.gluster.com>
To: 
CC: 




Kaleb KEITHLEY has uploaded a new change for review.

Change subject: config: better (i.e. more portable) test for libxml2
......................................................................

config: better (i.e. more portable) test for libxml2

Over the weekend I tried to build on MacOS X¹ and ran into the following
issues:
1) The recent change to autogen.sh to test for pkg-config falls down.
2) After removing the pkg-config test in autogen.sh, w/o pkg-config the
   PKG_CHECK_MODULES macro invocation in configure[.ac] falls down. N.B.
   Solaris users run into this too, even through there's a (broken)
   pkg-config package that can be installed.
3) There are other problems in the code related to fuse that are beyond the
   scope of this.

It seems that pkg-config is only a requirement for the definition of the
PKG_CHECK_MODULES macro used to detect libxml2. Since this seems to be
inherently unportable — at least to MacOS X and Solaris — I'd like to:
A) Change the use of the PKG_CHECK_MODULES macro to the more portable
   AM_PATH_XML2 macro provided by the libxml2 package in
   /usr/.../share/aclocal/libxml.m4
2) Revisit the decision to add the check for pkg-config in autogen.sh in
   BZ 921817.

For now this is just an rfc. If people are agreeable I'll reopen BZ 921817
and reenter this change.

¹Snow Leopard 10.8.3, XCode 4.6.1

Change-Id: I237b1ed8919088345b8fd943423b2a6ad289981b
Signed-off-by: Kaleb S. KEITHLEY <kkeithle at redhat.com>
---
M autogen.sh
M configure.ac
2 files changed, 1 insertion(+), 10 deletions(-)


  git pull ssh://git.gluster.org/glusterfs refs/changes/20/4720/1
--
To view, visit http://review.gluster.org/4720
To unsubscribe, visit http://review.gluster.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I237b1ed8919088345b8fd943423b2a6ad289981b
Gerrit-PatchSet: 1
Gerrit-Project: glusterfs
Gerrit-Branch: master
Gerrit-Owner: Kaleb KEITHLEY <kkeithle at redhat.com>