[Gluster-devel] Need review for client-reopen changes

Pranith Kumar Karampuri pkarampu at redhat.com
Mon Jan 7 04:45:36 UTC 2013


are the changes I made to handle re-opens of files in the case where a disk is replaced while a brick is offline. The idea is to attempt re-opens after self-heal completes and the file could be opened. With these changes readv/fxattrop/writev/findelk for fds with remote-fd -1 are attempted using anon-fds and if the fop succeeds then the re-open is attempted for every 1024th success. 1024 is an arbitrary number I used. The re-open of files could fail because of posix lock re-acquisition failure, that is the reason re-opens are attempted periodically (for every 1024 successful fops on that fd).

I think the re-attempt logic could be better.
For instance, we can attempt re-open on the first success on anon-fd instead of waiting till 1024th success and if this re-open fails we could fall-back on 'periodic attempts' i.e. for every 1024 successes on the anon-fd.

Let me know your thoughts.


More information about the Gluster-devel mailing list