[Gluster-devel] Fwd: New Defects reported by Coverity Scan for GlusterFS

[Krutika Dhananjay]

----- Original Message -----

> From: "Vijay Bellur" <vbellur at redhat.com>
> To: "Lalatendu Mohanty" <lmohanty at redhat.com>, gluster-devel at nongnu.org
> Sent: Tuesday, December 17, 2013 1:02:39 PM
> Subject: Re: [Gluster-devel] Fwd: New Defects reported by Coverity Scan for
> GlusterFS

> On 12/17/2013 11:17 AM, Lalatendu Mohanty wrote:
> >
> >
> > -------- Original Message --------
> > Subject: New Defects reported by Coverity Scan for GlusterFS
> > Date: Mon, 16 Dec 2013 12:49:25 -0800
> > From: scan-admin at coverity.com
> >
> >
> >
> > Hi,
> >
> >
> > Please find the latest report on new defect(s) introduced to GlusterFS
> > found with Coverity Scan.
> >
> > Defect(s) Reported-by: Coverity Scan
> > Showing 7 of 8 defect(s)
> >
> >
> > ** CID 1138525: Missing break in switch (MISSING_BREAK)
> > /xlators/mgmt/glusterd/src/glusterd-quota.c: 1407 in
> > glusterd_op_stage_quota()

> Raghavendra: Can you please confirm if this is an intentional "missing
> break"?
Vijay, 
The absence of a break statement in glusterd_op_stage_quota() is intentional. 

During stage-op, the act of fetching the gfid of the directory on which limit is to be set from local bricks, is common to both 
'limit-usage' and 'remove' sub-commands of quota, which explains the missing 'break' statement. 

-Krutika 

> >
> > ** CID 1138522: Destination buffer too small (BUFFER_SIZE)
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2926 in
> > glusterd_read_status_file()
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2928 in
> > glusterd_read_status_file()
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2904 in
> > glusterd_read_status_file()
> >
> > ** CID 1138523: Logically dead code (DEADCODE)
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2634 in
> > glusterd_parse_gsync_status()
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2654 in
> > glusterd_parse_gsync_status()
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2668 in
> > glusterd_parse_gsync_status()
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2624 in
> > glusterd_parse_gsync_status()
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2630 in
> > glusterd_parse_gsync_status()
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2650 in
> > glusterd_parse_gsync_status()
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2664 in
> > glusterd_parse_gsync_status()
> >
> > ** CID 1138524: Explicit null dereferenced (FORWARD_NULL)
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2679 in
> > glusterd_parse_gsync_status()
> >
> > ** CID 1138527: Resource leak (RESOURCE_LEAK)
> > /xlators/mgmt/glusterd/src/glusterd-utils.c: 4750 in _local_gsyncd_start()
> >
> > ** CID 1138526: Resource leak (RESOURCE_LEAK)
> > /xlators/mgmt/glusterd/src/glusterd-geo-rep.c: 2683 in
> > glusterd_parse_gsync_status()

> Ajeet, Avra: Can you please look into these defects?

> Thanks,
> Vijay

> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at nongnu.org
> https://lists.nongnu.org/mailman/listinfo/gluster-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://supercolony.gluster.org/pipermail/gluster-devel/attachments/20131217/6862914f/attachment-0001.html>