[Gluster-devel] new glusterfs logging framework

[Balamurugan Arumugam]

----- Original Message -----
> From: "Niels de Vos" <ndevos at redhat.com>
> To: "Balamurugan Arumugam" <barumuga at redhat.com>
> Cc: "Balamurugan Arumugam" <bala at gluster.com>, gluster-devel at nongnu.org, gluster-users at gluster.org
> Sent: Friday, August 9, 2013 3:19:42 PM
> Subject: Re: [Gluster-devel] new glusterfs logging framework
> 
> On Fri, Aug 09, 2013 at 04:47:45AM -0400, Balamurugan Arumugam wrote:
> > 
> > 
> > ----- Original Message -----
> > > From: "Niels de Vos" <ndevos at redhat.com>
> > > To: "Balamurugan Arumugam" <barumuga at redhat.com>
> > > Cc: "Balamurugan Arumugam" <bala at gluster.com>, gluster-devel at nongnu.org,
> > > gluster-users at gluster.org
> > > Sent: Thursday, August 8, 2013 2:46:38 PM
> > > Subject: Re: [Gluster-devel] new glusterfs logging framework
> > > 
> > > On Thu, Aug 08, 2013 at 04:44:01AM -0400, Balamurugan Arumugam wrote:
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Niels de Vos" <ndevos at redhat.com>
> > > > > To: "Balamurugan Arumugam" <bala at gluster.com>
> > > > > Cc: gluster-devel at nongnu.org, gluster-users at gluster.org
> > > > > Sent: Tuesday, August 6, 2013 8:48:58 PM
> > > > > Subject: Re: [Gluster-devel] new glusterfs logging framework
> > > > > 
> > > > > On Tue, Jul 30, 2013 at 05:29:43AM -0400, Balamurugan Arumugam wrote:
> > > > > > 
> > > > > > Hi All,
> > > > > > 
> > > > > > Recently new logging framework was introduced [1][2][3] in
> > > > > > glusterfs
> > > > > > master branch.  You could read more about this on doc/logging.txt.
> > > > > > In
> > > > > > brief, current log target is moved to syslog and user has an option
> > > > > > to
> > > > > > this new logging at compile time (passing '--disable-syslog' to
> > > > > > ./configure or '--without syslog' to rpmbuild) and run time (having
> > > > > > a file /var/log/glusterd/logger.conf and restarting gluster
> > > > > > services).
> > > > > > 
> > > > > > As rsyslog is used as syslog server in Fedora and CentOS/RHEL and
> > > > > > default configuration of rsyslog does not have any rule specific to
> > > > > > gluster logs, you see all logs are in /var/log/messages in JSON
> > > > > > format.
> > > > > 
> > > > > As the below does not function on RHEL-6 with its own rsyslog (no
> > > > > rsyslog-mmjsonparse available), I am creating an empty
> > > > > /var/lib/glusterd/logger.conf which (after a restart) makes glusterd
> > > > > and
> > > > > friends to log to their standard files again.
> > > > > 
> > > > > Do you have some progress on the rsyslog-mmjsonparse for rhel5 and
> > > > > rhel6?
> > > > > 
> > > > 
> > > > mmcount is a rsyslog plugin (developed by me) available rsyslog
> > > > upstream which tracks each gluster log using error codes.  The error
> > > > code is the entity enabled by gluster logging framework.  This module
> > > > is back ported to rhel6 which does tracking and json parsing.  I am in
> > > > the process of submitting this to rhel 6 downstream.  I haven't tried
> > > > rhel5 yet and I will do that too.
> > > 
> > > Very cool!
> > > 
> > > > > Also, it would really be nice to include that
> > > > > /etc/rsyslog.d/gluster.conf in the rpms and add a dependency on the
> > > > > rsyslog-mmjsonparse package. Or, provide a
> > > > > /var/lib/glusterd/logger.conf
> > > > > for the distributions that do not have rsyslog-mmjsonparse.
> > > > > 
> > > > 
> > > > Yes.  I had similar thought on this to do so.  I will send the fix
> > > > soon.
> > > 
> > > Great, thanks. Also, consider to move the file to /etc/glusterd where
> > > all configuration files that sysadmins may edit are kept.
> > > 
> > 
> > the logger.conf file will be placed into /etc/glusterfs/ directory.
> > The change is asked by jeo julian.  Let me know what you think.
> 
> Thanks, much better.
> 

BTW, rhel 5 doesn't have rsyslog.  I thought of disabling this frame work for rhel 5.  Also I submitted below patches which fixes issues in this framework

http://review.gluster.org/5541
http://review.gluster.org/5542
http://review.gluster.org/5543


Help on reviewing these patches would be really helpful

Thanks,
Bala



> Niels
>