[Gluster-devel] Proposed change in Gerrit workflow

Vijay Bellur vbellur at redhat.com
Tue Sep 25 10:43:11 UTC 2012


Hi All,

We intend to bring the following change in our gerrit based workflow:

- Introduce +2 and -2 for Verified in Gerrit
- +2 for Verified to be necessary for merging a patch

The intent of this proposed change is to get additional test coverage 
and reduce the number of regressions that can sneak by. Jenkins would 
continue to provide +1s for all submitted changes that pass basic smoke 
tests. An additional +2 would be necessary from somebody who tests the 
patch. Providing a +2 for Verified would be semantically similar to 
adding a Tested-by: tag.

Note that +1s are not additive in gerrit and hence a +2 verified would 
be necessary in addition to the +1 provided by Jenkins. Over time test 
scripts developed for verification can find a place in extras/test or in 
a better framework.

Please let us know your suggestions, comments or objections regarding 
this approach. If there are no objections, we will roll this change out 
by 09/28.

Thanks,
Vijay




More information about the Gluster-devel mailing list