[Gluster-devel] useless-if-before-free [Re: Change in glusterfs[release-3.2]: nfs: memory leak fixes

[Kaleb S. KEITHLEY]

On 07/10/2012 11:34 AM, Jim Meyering wrote:
> Hi guys,
> Any if-before-GF_FREE is almost certainly wasted effort,
> since GF_FREE already tests for NULL pointers.
> The added conditional generally makes the code
> a little harder to read/maintain.  (i.e., above)

Good point, and good catch. You should add your comments to the review 
in gerrit.


-- 

Kaleb