[Gluster-devel] swapcontest usage in syncio.c

[Anand Avati]

On Wed, Aug 8, 2012 at 10:19 PM, Emmanuel Dreyfus <manu at netbsd.org> wrote:

> Anand Avati <anand.avati at gmail.com> wrote:
>
> > I wonder how this will impact multi-thread syncproc. You might want to
> > #define SYNCENV_PROC_MAX to 1?
>
> What does it do? You mean instead of my proposed change?
>
>
Not "instead", but along. syncproc is a pthread which executes synctasks
(and syncops). So a synctask_set() performed in one syncproc will not be
obtained via synctask_get() performed in another (original) syncproc. So
instead of NULL we could get an unexpected (and maybe free'd/corrupted?)
synctask pointer. If we either avoid bouncing of synctasks between
syncprocs, or limit syncenv to a single syncproc, then your patch will be
"complete".

Avati
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://supercolony.gluster.org/pipermail/gluster-devel/attachments/20120808/ef1def08/attachment-0003.html>