[Gluster-devel] [PATCH BUG:361 2/3] OS X: fnctl() flag FNM_EXTMATCH is not supported under Mac OS X

[Amar Tumballi]

On Tue, Sep 28, 2010 at 1:18 AM, noah williamsson <
noah.williamsson at gmail.com> wrote:

> 2010/9/27 Amar Tumballi <amar at gluster.com>:
> > How about having
> >
> > #define FNM_EXTMATCH 0
> >
> > in #ifdef DARWIN_OS section of 'libglusterfs/src/compat.h' file??
> >
> > Idea is to have as less as possible OS specific code inside core, and
> handle
> > maximum possible things in compat.{c,h}
> >
>
> That would indeed be more elegant, however, given the fact that
> FNM_EXTMATCH is a GNU fnmatch() extension, maybe it should be
> considered to get rid of its use completely to get a consistent
> behavior across different OSes?
>
>
That was thought of.. Will check with the team again, and resolve this.
Better is to remove GNU specific flags from 'fnmatch()'.

-Amar
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://supercolony.gluster.org/pipermail/gluster-devel/attachments/20100928/7eb1401d/attachment-0003.html>