[Gluster-devel] Re: Possible leaks and so on

[Csaba Henk]

Hi Patrick,

On 2010-03-22, Vijay Bellur <vijay at gluster.com> wrote:
> Some of the issues reported are valid and they will be addressed through 
> this bug:
>
> http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=748

We have already run cppchek on the source:

http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=420

However, it didn't cough up those code points you mention -- see eg.:

$ cppcheck --force build/libglusterfs/src/y.tab.c
Checking build/libglusterfs/src/y.tab.c...
Checking build/libglusterfs/src/y.tab.c: YYENABLE_NLS...
Checking build/libglusterfs/src/y.tab.c: YYENABLE_NLS;ENABLE_NLS...
Checking build/libglusterfs/src/y.tab.c: YYLEX_PARAM...
Checking build/libglusterfs/src/y.tab.c: YYLLOC_DEFAULT...
Checking build/libglusterfs/src/y.tab.c: YYLTYPE_IS_TRIVIAL...
Checking build/libglusterfs/src/y.tab.c: YYPARSE_PARAM...
Checking build/libglusterfs/src/y.tab.c: YYPRINT...
Checking build/libglusterfs/src/y.tab.c: YYSTACK_RELOCATE...
Checking build/libglusterfs/src/y.tab.c: YYTYPE_INT16...
Checking build/libglusterfs/src/y.tab.c: YYTYPE_INT8...
Checking build/libglusterfs/src/y.tab.c: YYTYPE_UINT16...
Checking build/libglusterfs/src/y.tab.c: YYTYPE_UINT8...
Checking build/libglusterfs/src/y.tab.c: YY_...
Checking build/libglusterfs/src/y.tab.c: YY_LOCATION_PRINT...
Checking build/libglusterfs/src/y.tab.c: _GNU_SOURCE;_STRING_H;__GLIBC__...
Checking build/libglusterfs/src/y.tab.c: _STRING_H;__GLIBC__...
Checking build/libglusterfs/src/y.tab.c: __SIZE_TYPE__...
Checking build/libglusterfs/src/y.tab.c: lint...
Checking build/libglusterfs/src/y.tab.c: short...
Checking build/libglusterfs/src/y.tab.c: size_t...
Checking build/libglusterfs/src/y.tab.c: yyoverflow...
Checking build/libglusterfs/src/y.tab.c: yytnamerr...

So, besides saying thanks for pointing these out, may I ask what did you
do differently?

Ehhhrm, to prevent you in telling me "RTFM", I looked at the options so
this time I also tried with

$ cppcheck -a --force build/libglusterfs/src/y.tab.c

still I get only this one:

./libglusterfs/src/y.tab.c:1743]: (error) Memory leak: node

but not this one:

[./libglusterfs/src/y.tab.c:2067]: (error) Memory leak: cmd

I'm confused.

Csaba