[Gluster-devel] glusterfs cannot get spec from remote.

[Amar Tumballi]

Hi Kirby,
Can you send patches against latest git repository ?

Procedure given here:
http://gluster.org/docs/index.php/Development_Work_Flow

We already have fix for (2), in a different way, which works now.

Thanks,
Amar

On Sun, Mar 15, 2009 at 4:00 AM, Kirby Zhou <kirbyzhou at sohu-rd.com> wrote:

>  Some code reviews:
>
>
>
> 1.       *./transport/socket/src/socket.c:socket_submit* maybe conflict
> with *./xlators/protocol/client/src/client-protocol.c:protocol_client_xfer
> *
>
>
>
> 694                 if (conn->connected ||
>
> 695                     ((type == GF_OP_TYPE_MOP_REQUEST) &&
>
> 696                      (op == GF_MOP_SETVOLUME))) {
>
> 697                         ret = transport_submit (trans, (char *)hdr,
> hdrlen,
>
> 698                                                 vector, count, refs);
>
>
>
> 1211         pthread_mutex_lock (&priv->lock);
>
> 1212         {
>
> 1213                 if (priv->connected != 1) {
>
> 1214                         if (!priv->submit_log &&
> !priv->connect_finish_log) {
>
> 1215                                 gf_log (this->xl->name, GF_LOG_ERROR,
>
> 1216                                         "not connected
> (priv->connected = %d)",
>
> 1217                                         priv->connected);
>
> 1218                                 priv->submit_log = 1;
>
> 1219                         }
>
> 1220                         goto unlock;
>
> 1221                 }
>
>
>
> It seems if a socket is not connected finally, *protocol_client_xfer*would try to submit GF_MOP_SETVOLUME, but
> *socket_submit* would reject it.
>
>
>
> 2.       fetch-spec.c seems broken.
>
> if CHANNEL_BULK is connected after CHANNEL_LOWLAT, the fetch_spec would
> exit incorrectly.
>
>
>
> I have a patch here:
>
>
>
> 3.       mount.glusterfs would hang if no augments are given
>
>
>
> I also have a patch here
>
>
>
> 4.       cannot build on RHEL/CentOS/Fedora, the most popular RPM-based
> system. Because glusters requires ‘apache-devel’, actually it would be
> ‘httpd-devel’
>
>
>
> I also have a patch here
>
>
>
>
>
>
>
> *From:* Kirby Zhou [mailto:kirbyzhou at sohu-rd.com]
> *Sent:* Sunday, March 15, 2009 2:36 PM
> *To:* 'Kirby Zhou'; gluster-devel at nongnu.org
> *Subject:* RE: [Gluster-devel] glusterfs cannot get spec from remote.
>
>
>
> Version 2.0.0rc4
>
>
>
>
>
> *From:* gluster-devel-bounces+kirbyzhou=sohu-rd.com at nongnu.org [mailto:
> gluster-devel-bounces+kirbyzhou <gluster-devel-bounces%2Bkirbyzhou>=
> sohu-rd.com at nongnu.org] *On Behalf Of *Kirby Zhou
> *Sent:* Sunday, March 15, 2009 2:35 PM
> *To:* gluster-devel at nongnu.org
> *Subject:* [Gluster-devel] glusterfs cannot get spec from remote.
>
>
>
> For example:
>
>
>
> [root at xen-727057 ~]# glusterfs --no-daemon --volfile-server 10.10.123.21
> --volfile-server-port 6986 /mnt
>
> error while getting volume file from server 10.10.123.21
>
> Try `glusterfs --help' or `glusterfs --usage' for more information.
>
>
>
> Using tcpdump to capture packages, there is no requite to be sent:
>
>
>
> [root at xen-727057 ~]# tcpdump tcp port 6986 -n
>
> tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
>
> listening on eth0, link-type EN10MB (Ethernet), capture size 96 bytes
>
> 14:31:22.584355 IP 10.10.63.202.1023 > 10.10.123.21.6986: S
> 2145611414:2145611414(0) win 5840 <mss 1460,sackOK,timestamp 230654970
> 0,nop,wscale 7>
>
> 14:31:22.584535 IP 10.10.123.21.6986 > 10.10.63.202.1023: S
> 2304819495:2304819495(0) ack 2145611415 win 5840 <mss 1460>
>
> 14:31:22.584569 IP 10.10.63.202.1023 > 10.10.123.21.6986: . ack 1 win 5840
>
> 14:31:22.588027 IP 10.10.63.202.1022 > 10.10.123.21.6986: S
> 2148558987:2148558987(0) win 5840 <mss 1460,sackOK,timestamp 230654971
> 0,nop,wscale 7>
>
> 14:31:22.588208 IP 10.10.123.21.6986 > 10.10.63.202.1022: S
> 2307519548:2307519548(0) ack 2148558988 win 5840 <mss 1460>
>
> 14:31:22.588225 IP 10.10.63.202.1022 > 10.10.123.21.6986: . ack 1 win 5840
>
> 14:31:22.588805 IP 10.10.63.202.1023 > 10.10.123.21.6986: F 1:1(0) ack 1
> win 5840
>
> 14:31:22.588827 IP 10.10.63.202.1022 > 10.10.123.21.6986: F 1:1(0) ack 1
> win 5840
>
> 14:31:22.589014 IP 10.10.123.21.6986 > 10.10.63.202.1022: F 1:1(0) ack 2
> win 5840
>
> 14:31:22.589026 IP 10.10.63.202.1022 > 10.10.123.21.6986: . ack 2 win 5840
>
> 14:31:22.589187 IP 10.10.123.21.6986 > 10.10.63.202.1023: F 1:1(0) ack 2
> win 5840
>
> 14:31:22.589197 IP 10.10.63.202.1023 > 10.10.123.21.6986: . ack 2 win 5840
>
>
>
>
>
>
>
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at nongnu.org
> http://lists.nongnu.org/mailman/listinfo/gluster-devel
>
>


-- 
Amar Tumballi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://supercolony.gluster.org/pipermail/gluster-devel/attachments/20090317/703afc69/attachment-0003.html>