[Gluster-devel] Two patches against glusterfs-1.3.10

[Mateusz Korniak]

On Thursday 14 of August 2008, Amar S. Tumballi wrote:
>  I just upgraded to gcc-4.3.1 and tried to compile with and without LDADD,
> and with both things glusterfs worked fine. (even the translator linking).
>
>  (I just checked posix and client protocol translators, [on qa34 tarball]
> but the behavior should be same for all translators).

Perhaps it's more libtool related issue...

What versions you are using comparing to mine:

$ rpm -q libtool automake autoconf gcc glibc
libtool-2.2.4-4.i686
automake-1.10.1-1.i686
autoconf-2.62-2.noarch
gcc-4.3.1-3.i686
glibc-2.8-7.i686

?

Anyway I am almost done with patch which seems to works for me in above build 
env and also older one:

$ rpm -q libtool automake autoconf gcc glibc
libtool-1.5.26-2.athlon
automake-1.10-1.athlon
autoconf-2.61-3.noarch
gcc-3.3.6-9.athlon
glibc-2.3.6-14.athlon

I have only fix linking issues of glusterfs-booster.so...


> 2008/8/13 Mateusz Korniak <mateusz-lists at ant.gliwice.pl>
>
> > On Wednesday 13 of August 2008, Mateusz Korniak wrote:
> > > >  Thanks for the patches, they are committed to mainline now :-) [In
> >
> > both
> >
> > > > branches]
> > >
> > > Hi, Amar
> > >
> > > Unfortunately link patch solves only build issues.
> > > When trying to start glusterfs client I get:
> > >
> > > 2008-08-13 10:04:23 E [xlator.c:120:xlator_set_type] xlator:
> > > dlopen(/usr/lib/glusterfs/1.3.10/xlator/protocol/client.so):
> > > /usr/lib/glusterfs/1.3.10/xlator/protocol/client.so: cannot dynamically
> > > load executable
> >
> > I found solution to that problem which seems be:
> > change xlator_PROGRAMS to xlator_LTLIBRARIES so
> > whole Makefile.am looks like [1] which seems to produce proper valid
> > shared object [2]. I will test that solution and provide you with another
> > version of
> > link patch.
> > Sorry for inconvenience, best wishes and regards,
> >
> >
> > [1]:
> > # xlator_PROGRAMS = client.so
> >
> > version_type = None
> > xlator_LTLIBRARIES = client.la
> >
> > xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/protocol
> >
> > # client_so_SOURCES = client-protocol.c
> > # client_so_LDADD =
> > $(top_builddir)/libglusterfs/src/.libs/libglusterfs.so
> >
> > client_la_SOURCES = client-protocol.c
> >
> > ## client_la_LIBADD = $(top_srcdir)/libglusterfs/src/libglusterfs.la
> >
> > client_la_LDFLAGS  = -module -avoid-version
> >
> > noinst_HEADERS = client-protocol.h
> >
> > AM_CFLAGS = -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Wall
> > -D$(GF_HOST_OS) \
> >        -I$(top_srcdir)/libglusterfs/src -shared -nostartfiles
> > $(GF_DARWIN_BUNDLE_CFLAGS)
> >
> > CLEANFILES = *~
> >
> > [2]
> > file client.so
> > client.so: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV),
> > dynamically linked, stripped
> >
> > --
> > Mateusz Korniak



-- 
Mateusz Korniak