[Bugs] [Bug 1529488] entries not getting cleared post healing of softlinks ( stale entries showing up in heal info)

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1529488

Ravishankar N <ravishankar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|rhs-bugs at redhat.com,        |
                   |storage-qa-internal at redhat. |
                   |com                         |



--- Comment #4 from Ravishankar N <ravishankar at redhat.com> ---
Just recording what was happening without the fix, with the test in the
description so that its easier without going through all review comments in the
patch/ trying it out again.

When we delete the symlink from the brick (and not the .glusterfs hardlink to
it) and do look up from mount ,name heal will create a new inode. Thus the
.glusterfs entry and the symlink are no longer hardlinks to each other.

This will cause metadata self-heal (setfattr) on the sink to fail:
-----------------------------------------------------------------------------
[2018-07-13 08:56:45.834709] E [posix-handle.c:334:posix_is_malformed_link]
(--> /usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x1ee)[0x7f15b63622b0]
(-->
/usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x10b1a)[0x7f15a7b7db1a]
(-->
/usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x10cb5)[0x7f15a7b7dcb5]
(-->
/usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x1108b)[0x7f15a7b7e08b]
(-->
/usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x8a39)[0x7f15a7b75a39]
))))) 0-patchy-posix: malformed internal link FILE for
/d/backends/patchy2/.glusterfs/53/4a/534ac265-b7f4-4a72-b621-6cc1c770b133
[2018-07-13 08:56:45.834784] E [MSGID: 113097]
[posix-helpers.c:704:posix_istat] 0-patchy-posix: Failed to create handle path
for 534ac265-b7f4-4a72-b621-6cc1c770b133/ [Stale file handle]
[2018-07-13 08:56:45.835132] E [posix-handle.c:334:posix_is_malformed_link]
(--> /usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x1ee)[0x7f15b63622b0]
(-->
/usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x10b1a)[0x7f15a7b7db1a]
(-->
/usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x10cb5)[0x7f15a7b7dcb5]
(-->
/usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x1108b)[0x7f15a7b7e08b]
(-->
/usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x2a18b)[0x7f15a7b9718b]
))))) 0-patchy-posix: malformed internal link FILE for
/d/backends/patchy2/.glusterfs/53/4a/534ac265-b7f4-4a72-b621-6cc1c770b133
[2018-07-13 08:56:45.835176] E [MSGID: 113091]
[posix-inode-fd-ops.c:321:posix_setattr] 0-patchy-posix: Failed to create inode
handle for path /SOFTLINK
[2018-07-13 08:56:45.835202] E [MSGID: 113018]
[posix-inode-fd-ops.c:327:posix_setattr] 0-patchy-posix: setattr (lstat) on
<null> failed
[2018-07-13 08:56:45.835300] I [MSGID: 115072]
[server-rpc-fops_v2.c:1612:server4_setattr_cbk] 0-patchy-server: 13110: SETATTR
/SOFTLINK (534ac265-b7f4-4a72-b621-6cc1c770b133), client:
CTX_ID:b242a09f-a32b-4019-b42b-7b8830e458fc-GRAPH_ID:0-PID:15159-HOST:ravi3-PC_NAME:patchy-client-2-RECON_NO:-0,
error-xlator: -

-----------------------------------------------------------------------------
v1 of the patch tried to fix the issue by deleting the stale .glusterfs entry
during  posix_symlink () (sent during selfheal)

v2 of the patch onwards fixes it by deleting it in lookup.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=87xZiwiaIm&a=cc_unsubscribe