[Bugs] [Bug 1597229] glustershd crashes when index heal is launched before graph is initialized.

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 2 17:14:26 UTC 2018


https://bugzilla.redhat.com/show_bug.cgi?id=1597229

Worker Ant <bugzilla-bot at gluster.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/20435 committed in release-4.1 by
"Ravishankar N" <ravishankar at redhat.com> with a commit message- glusterfsd: Do
not process GLUSTERD_BRICK_XLATOR_OP if graph is not ready

Problem:
If glustershd gets restarted by glusterd due to node reboot/volume start force/
or any thing that changes shd graph (add/remove brick), and index heal
is launched via CLI, there can be a chance that shd receives this IPC
before the graph is fully active. Thus when it accesses
glusterfsd_ctx->active, it crashes.

Fix:
Since glusterd does not really wait for the daemons it spawned to be
fully initialized and can send the request as soon as rpc initialization has
succeeded, we just handle it at shd. If glusterfs_graph_activate() is
not yet done in shd but glusterd sends GD_OP_HEAL_VOLUME to shd,
we fail the request.

Change-Id: If6cc07bc5455c4ba03458a36c28b63664496b17d
fixes: bz#1597229
Signed-off-by: Ravishankar N <ravishankar at redhat.com>
(cherry picked from commit 2f9e555f79ce69668950693ed2e09cfafd2b7ec1)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list