[Bugs] [Bug 1546627] New: Syntactical errors in hook scripts for managing SELinux context on bricks

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1546627

            Bug ID: 1546627
           Summary: Syntactical errors in hook scripts for managing
                    SELinux context on bricks
           Product: GlusterFS
           Version: 3.12
         Component: scripts
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: jthottan at redhat.com
                CC: amukherj at redhat.com, anoopcs at redhat.com,
                    bugs at gluster.org, mzink at redhat.com
        Depends On: 1533342



+++ This bug was initially created as a clone of Bug #1533342 +++

Description of problem:
The sole purpose of S10selinux-label-brick.sh hook script is to set required
SELinux context on bricks after the volume is created. But the following error
is seen during its execution:

/var/lib/glusterd/hooks/1/create/post/S10selinux-label-brick.sh: line 46:
syntax error near unexpected token ('
/var/lib/glusterd/hooks/1/create/post/S10selinux-label-brick.sh: line 46:
semanage fcontext --add -t glusterd_brick_t -r s0 $b(/.*)?'

making it useless. Similar might be the case with S10selinux-del-fcontext.sh.

Version-Release number of selected component (if applicable):
master

How reproducible:
Always

Steps to Reproduce:
1. Try executing the mentioned hook script independently after creating the
volume.

Actual results:
Execution fails with error

Expected results:
Script must run successfully

--- Additional comment from Worker Ant on 2018-01-11 01:06:55 EST ---

REVIEW: https://review.gluster.org/19177 (extras/hooks: Fix
S10selinux-label-brick.sh hook script) posted (#3) for review on master by
Anoop C S

--- Additional comment from Anoop C S on 2018-01-11 01:09:20 EST ---

REVIEW: https://review.gluster.org/19177 (extras/hooks: Fix
S10selinux-label-brick.sh hook script) posted (#3) for review on master by
Milan Zink (zeten30 at gmail.com)

--- Additional comment from Milan Zink on 2018-01-12 05:02:48 EST ---

Reviewed, looks good - https://review.gluster.org/19177

--- Additional comment from Atin Mukherjee on 2018-01-14 10:05:33 EST ---

Until and unless the patch is merged, please don't change the bug status :)

--- Additional comment from Worker Ant on 2018-01-31 02:04:26 EST ---

COMMIT: https://review.gluster.org/19177 committed in master by "Amar Tumballi"
<amarts at redhat.com> with a commit message- extras/hooks: Fix
S10selinux-label-brick.sh hook script

* script was failng due to syntax error
* shellcheck issues fixed
* improved performance: semanage & restorecon is being run on unique path

Change-Id: I58b357d9fd37586004a2a518f7a5d1c5c9ddd7e3
BUG: 1533342
Signed-off-by: Milan Zink <zeten30 at gmail.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1533342
[Bug 1533342] Syntactical errors in hook scripts for managing SELinux
context on bricks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.