[Bugs] [Bug 1496238] New: [geo-rep]: Scheduler help needs correction for description of --no-color

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1496238

            Bug ID: 1496238
           Summary: [geo-rep]: Scheduler help needs correction for
                    description of --no-color
           Product: GlusterFS
           Version: 3.12
         Component: geo-replication
          Severity: low
          Assignee: bugs at gluster.org
          Reporter: khiremat at redhat.com
                CC: avishwan at redhat.com, bugs at gluster.org,
                    csaba at redhat.com, rhinduja at redhat.com,
                    rhs-bugs at redhat.com, storage-qa-internal at redhat.com
        Depends On: 1475466, 1495436



+++ This bug was initially created as a clone of Bug #1495436 +++

Description of problem:
-----------------------

Currently the description of --no-color in the help of schedule_georep is "Use
Color in CLI output". Whereas the default is with color, and if user provides
this option, that means no color will be seen in the output and hence the
description should be:

--no-color           Do not Use Color in CLI output

Output:
-------

[root at dhcp42-79 MASTER]#  python
/usr/share/glusterfs/scripts/schedule_georep.py --h
usage: schedule_georep.py [-h] [--interval INTERVAL] [--timeout TIMEOUT]
                          [--no-color]
                          mastervol SLAVE slavevol

Schedule Geo-replication
------------------------
A tool to run Geo-replication when required. This can be used to
schedule the Geo-replication to run once in a day using

   # Run daily at 08:30pm
   30 20 * * * root python /usr/share/glusterfs/scripts/schedule_georep.py \
      --no-color gv1 fvm1 gv2 >> /var/log/glusterfs/schedule_georep.log 2>&1

This tool does the following,

1. Stop Geo-replication if Started
2. Start Geo-replication
3. Set Checkpoint
4. Check the Status and see Checkpoint is Complete.(LOOP)
5. If checkpoint complete, Stop Geo-replication

Usage:

    python /usr/share/glusterfs/scripts/schedule_georep.py <MASTERVOL> \
         <SLAVEHOST> <SLAVEVOL>

For example,

    python /usr/share/glusterfs/scripts/schedule_georep.py gv1 fvm1 gv2

positional arguments:
  mastervol            Master Volume Name
  SLAVE                SLAVEHOST or root at SLAVEHOST or user at SLAVEHOST
  slavevol             Slave Volume Name

optional arguments:
  -h, --help           show this help message and exit
  --interval INTERVAL  Interval in Seconds. Wait time before each status check
  --timeout TIMEOUT    Timeout in minutes. Script will stop Geo-replication if
                       Checkpoint is not complete in the specified timeout
                       time
  --no-color           Use Color in CLI output
[root at dhcp42-79 MASTER]# 


Version-Release number of selected component (if applicable):
=============================================================

mainline

--- Additional comment from Worker Ant on 2017-09-25 23:56:09 EDT ---

REVIEW: https://review.gluster.org/18388 (geo-rep/scheduler: Fix '--no-color'
help msg) posted (#1) for review on master by Kotresh HR (khiremat at redhat.com)

--- Additional comment from Worker Ant on 2017-09-26 05:28:49 EDT ---

COMMIT: https://review.gluster.org/18388 committed in master by Aravinda VK
(avishwan at redhat.com) 
------
commit 8855ebcfecde2a21e0a9ba725e9738708e03904a
Author: Kotresh HR <khiremat at redhat.com>
Date:   Mon Sep 25 23:34:55 2017 -0400

    geo-rep/scheduler: Fix '--no-color' help msg

    Change-Id: I0f51558083e0b11a6563b8a2ef62ec07fe2a9ca9
    BUG: 1495436
    Signed-off-by: Kotresh HR <khiremat at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1475466
[Bug 1475466] [geo-rep]: Scheduler help needs correction for description of
--no-color
https://bugzilla.redhat.com/show_bug.cgi?id=1495436
[Bug 1495436] [geo-rep]: Scheduler help needs correction for description of
--no-color
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.