[Bugs] [Bug 1488909] Fix the type of 'len' in posix.c, clang is showing a warning

bugzilla at redhat.com bugzilla at redhat.com
Fri Sep 8 16:16:58 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1488909



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/18220 committed in master by Jeff Darcy
(jeff at pl.atyp.us) 
------
commit c6c526010fa4b9d9628e445036e8f84b00bfb9a8
Author: Michael Scherer <misc at redhat.com>
Date:   Wed Sep 6 14:46:20 2017 +0200

    Fix the type of len, a warning is triggered

    clang show this warning on FreeBSD:

      posix.c:133:17: warning: comparison of unsigned expression < 0
      is always false [-Wtautological-compare]

    A closer look on the code show that sys_readlink is returning a ssize_t,
    not a size_t, who is unsigned.

    Change-Id: Idb6a440ea44cc2168b0dd85f791c7955caa67c8c
    BUG: 1488909
    Signed-off-by: Michael Scherer <misc at redhat.com>
    Reviewed-on: https://review.gluster.org/18220
    Tested-by: Michael Scherer <misc at fedoraproject.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jeff at pl.atyp.us>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list