[Bugs] [Bug 1489511] New: return ENOSYS for 'non readable' FOPs

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1489511

            Bug ID: 1489511
           Summary: return ENOSYS for 'non readable' FOPs
           Product: GlusterFS
           Version: 3.12
         Component: arbiter
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ravishankar at redhat.com
                CC: bugs at gluster.org, ndevos at redhat.com
        Depends On: 1484722



+++ This bug was initially created as a clone of Bug #1484722 +++

Description of problem:
feedback at https://review.gluster.org/#/c/18103/1//COMMIT_MSG@15 :

AFR marks the arbiter brick as 'non readable', so any read-based FOP won't be
sent on it.(See: http://review.gluster.org/13539). So I don't think this change
is really needed. After 13539, even arbiter_readv() won't be hit as well.

It might be a good idea to have this defensive fix (unwind the FOP with
failure) in the rogue case AFR does wind the read fop to arbiter.


Expected results:
No change in behaviour, AFR should not call the FOPs from the arbiter xlator in
any case.

--- Additional comment from Worker Ant on 2017-08-24 04:28:42 EDT ---

REVIEW: https://review.gluster.org/18103 (arbiter: return ENOTCONN for 'non
readable' FOPs) posted (#2) for review on master by Niels de Vos
(ndevos at redhat.com)

--- Additional comment from Worker Ant on 2017-09-04 09:08:48 EDT ---

REVIEW: https://review.gluster.org/18103 (arbiter: return ENOTCONN for 'non
readable' FOPs) posted (#3) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-09-05 02:00:22 EDT ---

REVIEW: https://review.gluster.org/18103 (arbiter: return ENOTCONN for 'non
readable' FOPs) posted (#4) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-09-05 04:36:47 EDT ---

REVIEW: https://review.gluster.org/18103 (arbiter: return ENOSYS for 'non
readable' FOPs) posted (#5) for review on master by Niels de Vos
(ndevos at redhat.com)

--- Additional comment from Worker Ant on 2017-09-05 10:03:43 EDT ---

COMMIT: https://review.gluster.org/18103 committed in master by Ravishankar N
(ravishankar at redhat.com) 
------
commit b1352d0974328b367afa7360e9523585efb7178d
Author: Niels de Vos <ndevos at redhat.com>
Date:   Wed Aug 23 18:18:24 2017 +0200

    arbiter: return ENOSYS for 'non readable' FOPs

    AFR marks the arbiter as 'non readable'. This has been introduced with
    commit 8ab87137 (afr: do not set arbiter as a readable subvol in inode
    context). arbiter_readv() should not get called anymore, so it could be
    removed. However, it is a good defensive approach to have all the inode
    read FOPs that can not be handled by the arbiter to return ENOSYS.

    Change-Id: I6ea41680832859bd6790dc8d7440ee98d38205fc
    BUG: 1484722
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: https://review.gluster.org/18103
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1484722
[Bug 1484722] return ENOSYS for 'non readable' FOPs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.