[Bugs] [Bug 1487033] rpc: client_t and related objects leaked due to incorrect ref counts
bugzilla at redhat.com
bugzilla at redhat.com
Thu Sep 7 06:49:56 UTC 2017
https://bugzilla.redhat.com/show_bug.cgi?id=1487033
--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/18156 committed in release-3.12 by jiffin
tony Thottan (jthottan at redhat.com)
------
commit e0335c32de133aafd88b888a0c20f4eb88bb9845
Author: Milind Changire <mchangir at redhat.com>
Date: Thu Aug 31 11:37:32 2017 +0530
rpc: destroy transport after client_t
Problem:
1. Ref counting increment on the client_t object is done in
rpcsvc_request_init() which is incorrect.
2. Ref not taken when delegating to grace_time_handler()
Solution:
1. Only fop requests which require processing down the graph via
stack 'frames' now ref count the request in get_frame_from_request()
2. Take ref on client_t object in server_rpc_notify() but avoid
dropping in RPCSVC_EVENT_TRANSPORT_DESRTROY. Drop the ref
unconditionally when exiting out of grace_time_handler().
Also, avoid dropping ref on client_t in
RPCSVC_EVENT_TRANSPORT_DESTROY when ref mangement as been
delegated to grace_time_handler()
mainline:
> BUG: 1481600
> Reported-by: Raghavendra G <rgowdapp at redhat.com>
> Signed-off-by: Milind Changire <mchangir at redhat.com>
> Reviewed-on: https://review.gluster.org/17982
> Tested-by: Raghavendra G <rgowdapp at redhat.com>
> Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
> CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
> Smoke: Gluster Build System <jenkins at build.gluster.org>
(cherry picked from commit 24b95089a18a6a40e7703cb344e92025d67f3086)
Change-Id: Ic16246bebc7ea4490545b26564658f4b081675e4
BUG: 1487033
Reported-by: Raghavendra G <rgowdapp at redhat.com>
Signed-off-by: Milind Changire <mchangir at redhat.com>
Reviewed-on: https://review.gluster.org/18156
Smoke: Gluster Build System <jenkins at build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
Tested-by: Raghavendra G <rgowdapp at redhat.com>
CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HMvDm8HkI8&a=cc_unsubscribe
More information about the Bugs
mailing list