[Bugs] [Bug 1452084] [Ganesha] : Stale linkto files after unsuccessfuly hardlinks

bugzilla at redhat.com bugzilla at redhat.com
Thu Jun 22 06:27:46 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1452084



--- Comment #8 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17331 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit 237648780336d41cd6d820c337b38dd13f4d9e72
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date:   Thu May 18 11:22:16 2017 +0530

    dht/hardlink : Remove stale linkto file incase of failure

    This is a similar issue fixed for rename in
https://review.gluster.org/#/c/16016/
    For hardlinks, if cached and hashed subvolumes are different, then it will
first
    create linkto file in hashed using root permission, but actually hardlink
creation
    fails with EACESS and stale linkto file is never removed.All the followup
hardlink
    calls with file name will result ESTALE because linktofile creation fails
with EEXIST
    and follow up lookup on linkto file returns gfid-mismatching(old linkto
file) and
    finally fails with ESTALE

    Steps to produce :
    (From link/00.t test from posix-testsuite)
    Steps executed in script
     * create a file "abc" using root
     * change the ownership of file to a non root user
     * create hardlink "link" for "abc" using a non root user, it fails with
EACESS
     * delete "abc"
     * create directory "abc" using root
     * again try to create hadrlink "link" for "abc" using non root user, fails
with ESTALE

    Also tried to fix other bugs in dht_linkfile_create_cbk() and posix_lookup.

    Thanks Susant for the help in debugging the issue and suggestion for this
patch.

    Change-Id: I7a5a1899d3fd1fdb13578b37f9d52a084492e35d
    BUG: 1452084
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Reviewed-on: https://review.gluster.org/17331
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: N Balachandran <nbalacha at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oVPvsodhb1&a=cc_unsubscribe


More information about the Bugs mailing list