[Bugs] [Bug 1463104] New: lk fop succeeds even when lock is not acquired on at least quorum number of bricks

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1463104

            Bug ID: 1463104
           Summary: lk fop succeeds even when lock is not acquired on at
                    least quorum number of bricks
           Product: Red Hat Gluster Storage
           Version: 3.3
         Component: replicate
          Assignee: ravishankar at redhat.com
          Reporter: pkarampu at redhat.com
        QA Contact: nchilaka at redhat.com
                CC: bugs at gluster.org, rhs-bugs at redhat.com,
                    storage-qa-internal at redhat.com
        Depends On: 1461792
            Blocks: 1462661



+++ This bug was initially created as a clone of Bug #1461792 +++

Description of problem:
When testing gluster-block we are seeing that even when just one of the bricks
is up lk fop is succeeding. This can lead to problems. Fix AFR behavior where
lk fop considers quorum count to decide if lk fop succeeds or not.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-06-15 07:20:05 EDT ---

REVIEW: https://review.gluster.org/17524 (cluster/afr: Implement quorum for lk
fop) posted (#3) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Worker Ant on 2017-06-18 12:36:29 EDT ---

REVIEW: https://review.gluster.org/17524 (cluster/afr: Implement quorum for lk
fop) posted (#4) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Worker Ant on 2017-06-19 01:17:32 EDT ---

COMMIT: https://review.gluster.org/17524 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 45ebcf7009f549f022c36b4d537eeac62ecfd020
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Mon Jun 12 22:06:18 2017 +0530

    cluster/afr: Implement quorum for lk fop

    Problem:
    At the moment when we have replica 3 or arbiter setup, even when
    lk succeeds on just one brick we give success to application which
    is wrong

    Fix:
    Consider quorum-number of successes as success when quorum is enabled.

    BUG: 1461792
    Change-Id: I5789e6eb5defb68f8a0eb9cd594d316f5cdebaea
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: https://review.gluster.org/17524
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Ravishankar N <ravishankar at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1461792
[Bug 1461792] lk fop succeeds even when lock is not acquired on at least
quorum number of bricks
https://bugzilla.redhat.com/show_bug.cgi?id=1462661
[Bug 1462661] lk fop succeeds even when lock is not acquired on at least
quorum number of bricks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hJXACmb5no&a=cc_unsubscribe