[Bugs] [Bug 1460661] "split-brain observed [Input/output error]" error messages in samba logs during parallel rm -rf

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1460661



--- Comment #5 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17517 committed in release-3.8 by jiffin
tony Thottan (jthottan at redhat.com) 
------
commit 0903b76c88ed47d819372763fdccbe1486bf4943
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Mon May 29 21:38:14 2017 +0530

    posix: use the correct op_errno

    Problem:
    If readdir/fstat was performed on a directory that was removed,
    posix_fd_ctx_get() fails with ENOENT but we incorrectly use the ret
    value (-1 in this case) as op_errno, logging "Operation not permitted"
    messages in the brick logs. Also in case of fstat, the -1 op_errno was
    also propagated to the client via stack unwind, causing the message to
    appear in protocol/client logs as well.

    Fix:
    Use the right op_errno in readdir, fstat and writev.
    A̶l̶s̶o̶,̶ ̶i̶f̶ p̶o̶s̶i̶x̶_̶f̶d̶_̶c̶t̶x̶_̶g̶e̶t̶(̶)̶ ̶f̶a̶i̶l̶e̶d̶
̶w̶i̶t̶h̶ ̶E̶N̶O̶E̶N̶T̶,̶ ̶c̶o̶n̶v̶e̶r̶t̶ ̶i̶t̶ ̶i̶n̶t̶o̶ ̶E̶B̶A̶D̶F̶
̶b̶e̶c̶a̶u̶s̶e̶ ̶E̶N̶O̶E̶N̶T̶
    i̶s̶ ̶n̶o̶t̶ ̶a̶ ̶v̶a̶l̶i̶d̶ ̶e̶r̶r̶o̶r̶ ̶f̶o̶r̶ ̶a̶n̶ ̶f̶d̶
̶o̶p̶e̶r̶a̶t̶i̶o̶n̶.̶ Don't do this as it breaks
    DHT.See 17565

    > Reviewed-on: https://review.gluster.org/17414
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    > Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > Reviewed-by: Amar Tumballi <amarts at redhat.com>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    (cherry picked from commit de92c363c95d16966dbcc9d8763fd4448dd84d13)

    Change-Id: Ie43c0789d5040ec73b7cf885d015a183b8c64d70
    BUG: 1460661
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: https://review.gluster.org/17517
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=exFw2Ijg8B&a=cc_unsubscribe