[Bugs] [Bug 1459095] New: extras/hook-scripts: non-portable shell syntax ( debian package maintainer)

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1459095

            Bug ID: 1459095
           Summary: extras/hook-scripts: non-portable shell syntax (debian
                    package maintainer)
           Product: GlusterFS
           Version: 3.11
         Component: scripts
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: kkeithle at redhat.com
                CC: bugs at gluster.org
        Depends On: 1457812



+++ This bug was initially created as a clone of Bug #1457812 +++

Description of problem:

use of "function" is not portable to other shells

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-06-01 07:08:09 EDT ---

REVIEW: https://review.gluster.org/17443 (extras/hookscripts: non-portable
shell syntax (debian package maintainer)) posted (#1) for review on master by
Kaleb KEITHLEY (kkeithle at redhat.com)

--- Additional comment from Worker Ant on 2017-06-01 08:03:22 EDT ---

REVIEW: https://review.gluster.org/17443 (extras/hookscripts: non-portable
shell syntax (debian package maintainer)) posted (#2) for review on master by
Kaleb KEITHLEY (kkeithle at redhat.com)

--- Additional comment from Worker Ant on 2017-06-02 07:41:30 EDT ---

REVIEW: https://review.gluster.org/17443 (extras/hookscripts: non-portable
shell syntax) posted (#3) for review on master by Kaleb KEITHLEY
(kkeithle at redhat.com)

--- Additional comment from Worker Ant on 2017-06-02 08:13:38 EDT ---

COMMIT: https://review.gluster.org/17443 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit be28cbc5f8d3a78f6968b0307d001a5c0f0d8b31
Author: Kaleb S. KEITHLEY <kkeithle at redhat.com>
Date:   Thu Jun 1 07:05:42 2017 -0400

    extras/hookscripts: non-portable shell syntax

    use of "function" is not portable to other shells

    Reported-by: Patrick Matthäi <pmatthaei at debian.org>
    Change-Id: I13a0482b387cc3b7a7a57df424e673850603da37
    BUG: 1457812
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle at redhat.com>
    Reviewed-on: https://review.gluster.org/17443
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1457812
[Bug 1457812] extras/hook-scripts: non-portable shell syntax (debian
package maintainer)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.