[Bugs] [Bug 1457901] New: nlc_lookup_cbk floods logs

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1457901

            Bug ID: 1457901
           Summary: nlc_lookup_cbk floods logs
           Product: GlusterFS
           Version: 3.11
         Component: unclassified
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ravishankar at redhat.com
                CC: bugs at gluster.org
        Depends On: 1456653



+++ This bug was initially created as a clone of Bug #1456653 +++

Description of problem:

    For nameless lookups, nl-cache does not init frame local, so the cbk
    throws up messages like these flooding the logs, especially whenenver
    gfid lookup on '/' is done (i.e. loc.path="/" and loc.gfid=1).

    [2017-05-30 04:35:31.628443] E [nl-cache.c:201:nlc_lookup_cbk]
    (-->/usr/lib64/glusterfs/3.8.4/xlator/performance/io-cache.so(+0x3d81)
    [0x7f0883005d81]
    -->/usr/lib64/glusterfs/3.8.4/xlator/performance/quick-read.so(+0x3127)
    [0x7f0882dfb127]
    -->/usr/lib64/glusterfs/3.8.4/xlator/performance/nl-cache.so(+0x4cd3)
    [0x7f08829e0cd3] ) 0-distrep-nl-cache: invalid argument: local [Invalid

--- Additional comment from Worker Ant on 2017-05-30 01:00:55 EDT ---

REVIEW: https://review.gluster.org/17417 (nl-cache: Initialze frame local
before stack wind) posted (#1) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-05-30 04:19:11 EDT ---

REVIEW: https://review.gluster.org/17417 (nl-cache: Initialze frame local
before stack wind) posted (#2) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-05-30 05:09:38 EDT ---

REVIEW: https://review.gluster.org/17417 (nl-cache: Remove null check
validation for frame->local in lookup cbk) posted (#3) for review on master by
Ravishankar N (ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-05-30 11:34:55 EDT ---

COMMIT: https://review.gluster.org/17417 committed in master by Jeff Darcy
(jeff at pl.atyp.us) 
------
commit ec86167d09bcbb763e31b73fb3d688efaa5444d7
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Tue May 30 10:18:04 2017 +0530

    nl-cache: Remove null check validation for frame->local in lookup cbk

    For nameless lookups, nl-cache does not init frame local, so the cbk
    throws up messages like these flooding the logs, especially whenenver
    gfid lookup on '/' is done (i.e. loc.path="/" and loc.gfid=1).

    [2017-05-30 04:35:31.628443] E [nl-cache.c:201:nlc_lookup_cbk]
    (-->/usr/lib64/glusterfs/3.8.4/xlator/performance/io-cache.so(+0x3d81)
    [0x7f0883005d81]
    -->/usr/lib64/glusterfs/3.8.4/xlator/performance/quick-read.so(+0x3127)
    [0x7f0882dfb127]
    -->/usr/lib64/glusterfs/3.8.4/xlator/performance/nl-cache.so(+0x4cd3)
    [0x7f08829e0cd3] ) 0-distrep-nl-cache: invalid argument: local [Invalid
    argument]

    Fixed it.

    Change-Id: I21cb44a9d2a324617e43f46fed83c9a0942d3a0b
    BUG: 1456653
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: https://review.gluster.org/17417
    Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Poornima G <pgurusid at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1456653
[Bug 1456653] nlc_lookup_cbk floods logs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.