[Bugs] [Bug 1476410] New: glusterd: code lacks clarity of logic in glusterd_get_quorum_cluster_counts()

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1476410

            Bug ID: 1476410
           Summary: glusterd: code lacks clarity of logic in
                    glusterd_get_quorum_cluster_counts()
           Product: GlusterFS
           Version: mainline
         Component: glusterd
          Assignee: bugs at gluster.org
          Reporter: madam at redhat.com
                CC: bugs at gluster.org



This is counter-intuitive:

ret = gf_string2percent (val, &quorum_percentage);
if (!ret)
    ratio = _gf_true;
...

since !ret sounds like failure but ret == 0 signifies success here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.