[Bugs] [Bug 1465559] multiple brick processes seen on gluster(fs) d restart in brick multiplexing

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1465559



--- Comment #6 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17840 committed in master by Jeff Darcy
(jeff at pl.atyp.us) 
------
commit d095c02eb9796ca2ec2a24931c28f057c403f834
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Thu Jul 20 18:11:14 2017 +0530

    glusterd: fix brick start race

    Problem:

    Another race where glusterd was restarted glusterd_brick_start () is called
    multiple times due to friend handshaking and in one instance when one of
the
    brick was attempted to be attached to the existing brick process,
    send_attach_req failed as the first brick itself was still not up and then
we
    did a synlock_unlock () followed by a sleep of 1 sec, before the same
thread
    woke up, another thread tried to start the same brick process and then it
    assumed that it has to start a fresh brick process.

    Solution:

    1. If brick is in starting phase (brickinfo->status ==
    GF_BRICK_STARTING), no need for a reattempt to
    start the brick.
    2. While initiating attach_req set brickinfo->status to
    GF_BRICK_STARTING

    Change-Id: Ib007b6199ec36fdab4214a1d37f99d7f65ef64da
    BUG: 1465559
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: https://review.gluster.org/17840
    Reviewed-by: Amar Tumballi <amarts at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jeff at pl.atyp.us>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t8aUx4KPUb&a=cc_unsubscribe