[Bugs] [Bug 1469179] invoke checkpatch.pl with strict

bugzilla at redhat.com bugzilla at redhat.com
Tue Jul 18 11:22:25 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1469179



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17737 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit 43d55c5afb1a9f731d806f7893923ac999b9ef6c
Author: Raghavendra Talur <rtalur at redhat.com>
Date:   Mon Jul 10 20:43:39 2017 +0530

    rfc.sh: make alignment check compulsory

    Earlier, it was not reported if a function call had arguments on next
    line and the args were not aligned to opening bracket. With this change,
    it is a check that is displayed in output.

    I have not analyzed what all --strict brings in. If it is found to be
    more restrictive than required, we may choose to promote this *one* CHK
    to WARN and stop using --strict.

    Sample:

    CHECK: Alignment should match open parenthesis
    +                ret = gf_asprintf (&footer,
    +                                " [%s]", strerror(errnum));

    total: 0 warnings, 1 checks, 8 lines checked

    Change-Id: I48834087efcae872b69746ba962b0bb1c130b5cd
    BUG: 1469179
    Signed-off-by: Raghavendra Talur <rtalur at redhat.com>
    Reviewed-on: https://review.gluster.org/17737
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Prashanth Pai <ppai at redhat.com>
    Reviewed-by: ankitraj
    Reviewed-by: Jeff Darcy <jeff at pl.atyp.us>
    Reviewed-by: Sonal Arora <sarora at redhat.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4r8llgU51t&a=cc_unsubscribe


More information about the Bugs mailing list