[Bugs] [Bug 1470489] bulk removexattr shouldn't allow removal of trusted.gfid/ trusted.glusterfs.volume-id

bugzilla at redhat.com bugzilla at redhat.com
Fri Jul 14 09:30:37 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1470489



--- Comment #5 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17765 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 11eb8ba870457337c6067284dde4277e09764c0a
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Wed Jul 12 09:18:02 2017 +0530

    storage/posix: Don't allow gfid/volume-id xattr to be removed

    Problem:
    Bulk xattr removal doesn't check if the xattrs that are coming in xdata
    have gfid/volume-id xattrs, so there is potential for bulkremovexattr
    removing gfid/volume-id.
    I also observed that bulkremovexattr is not available for fremovexattr.

    Fix:
    Do proper checks in bulk removexattr to remove gfid/volume-id.
    Refactor [f]removexattr to reduce the differences.

    BUG: 1470489
    Change-Id: Ia845b31846a149500111c0996646e648f72cdce6
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: https://review.gluster.org/17765
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jeff at pl.atyp.us>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Anuradha Talur <atalur at redhat.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-by: Krutika Dhananjay <kdhananj at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list