[Bugs] [Bug 1193929] GlusterFS can be improved

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1193929



--- Comment #18 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17753 committed in master by Jeff Darcy
(jeff at pl.atyp.us) 
------
commit 58a15ae04e597d6ab353f00a3ee72260c0b6f802
Author: Prashanth Pai <ppai at redhat.com>
Date:   Wed Jul 12 12:59:35 2017 +0530

    socket: call init_openssl_mt() in init() and add cleanup

    init_openssl_mt() wasn't explicitly invoked and was run implicitly before
    dlopen() returned as it was tagged as __attribute__ ((constructor)). This
    function used to call GF_CALLOC() which wasn't available or initialized
    when socket.so is dlopen()ed by an external program. The program used to
    crash with SIGSEGV as follows:

    0x00007ffff5efe1ad in __gf_calloc (nmemb=41, size=40, type=158,
typestr=0x7ffff63eb3d6 "gf_sock_mt_lock_array")
    at mem-pool.c:109
    0x00007ffff63e6acf in init_openssl_mt () at socket.c:4016
    0x00007ffff7de90da in call_init.part () from /lib64/ld-linux-x86-64.so.2
    0x00007ffff7de91eb in _dl_init () from /lib64/ld-linux-x86-64.so.2
    0x00007ffff7dedde1 in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
    0x00007ffff7de8f84 in _dl_catch_error () from /lib64/ld-linux-x86-64.so.2
    0x00007ffff7ded339 in _dl_open () from /lib64/ld-linux-x86-64.so.2

    This change moves call to init_openssl_mt() from being a constructor
function
    to the init() function and introduces fini_openssl_mt() which cleans up
    resources (called in destructor).

    BUG: 1193929
    Change-Id: Iab690897ec34e24c33f6b43f8d8d9f8fd75ac607
    Signed-off-by: Prashanth Pai <ppai at redhat.com>
    Reviewed-on: https://review.gluster.org/17753
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Amar Tumballi <amarts at redhat.com>
    Reviewed-by: Jeff Darcy <jeff at pl.atyp.us>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.