[Bugs] [Bug 1468863] Assert in mem_pools_fini during libgfapi-fini-hang.t on NetBSD

bugzilla at redhat.com bugzilla at redhat.com
Wed Jul 12 09:01:16 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1468863



--- Comment #7 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17734 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit a4a417e29c5b2d63e6bf5efae4f0ccf30a39647f
Author: Niels de Vos <ndevos at redhat.com>
Date:   Mon Jul 10 11:45:31 2017 +0200

    gfapi: prevent mem-pool leak in case glfs_new_fs() fails

    Commit 7039243e187 adds a call to mem_pools_init() so that the memory
    pool cleanup thread ("sweeper") is started. However, now it is possible
    that users of gfapi can not cleanup this thread because glfs_new() can
    return NULL, but the sweeper is still running.

    In case glfs_fs_new() fails, mem_pools_fini() needs to be called as
    well. This seems more correct than calling mem_pools_init() after
    glfs_fs_new(), and this makes using memory pools possible *really* early
    in the gfapi initialization.

    Change-Id: I1f2fb25cc33e227b3c33ce9d1b03f67bc27e981a
    Fixes: 7039243e187 ("gfapi: add mem_pools_init and mem_pools_fini calls")
    BUG: 1468863
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: https://review.gluster.org/17734
    Reviewed-by: Jeff Darcy <jeff at pl.atyp.us>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: soumya k <skoduri at redhat.com>
    Reviewed-by: Amar Tumballi <amarts at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list