[Bugs] [Bug 1462447] brick maintenance - no client reconnect
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jul 11 13:25:44 UTC 2017
https://bugzilla.redhat.com/show_bug.cgi?id=1462447
--- Comment #12 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17743 committed in release-3.8 by Niels de
Vos (ndevos at redhat.com)
------
commit 96e7452155c3fd1b160a97d88c03f1bf31b0be97
Author: Atin Mukherjee <amukherj at redhat.com>
Date: Sat Mar 18 16:29:10 2017 +0530
rpc: bump up conn->cleanup_gen in rpc_clnt_reconnect_cleanup
Commit 086436a introduced generation number (cleanup_gen) to ensure that
rpc layer doesn't end up cleaning up the connection object if
application layer has already destroyed it. Bumping up cleanup_gen was
done only in rpc_clnt_connection_cleanup (). However the same is needed
in rpc_clnt_reconnect_cleanup () too as with out it if the object gets
destroyed
through the reconnect event in the application layer, rpc layer will
still end up in trying to delete the object resulting into double free
and crash.
Peer probing an invalid host/IP was the basic test to catch this issue.
Cherry picked from commit 39e09ad1e0e93f08153688c31433c38529f93716:
> Change-Id: Id5332f3239cb324cead34eb51cf73d426733bd46
> BUG: 1433578
> Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
> Reviewed-on: https://review.gluster.org/16914
> Smoke: Gluster Build System <jenkins at build.gluster.org>
> NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
> Reviewed-by: Milind Changire <mchangir at redhat.com>
> CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
> Reviewed-by: Jeff Darcy <jeff at pl.atyp.us>
Change-Id: Id5332f3239cb324cead34eb51cf73d426733bd46
BUG: 1462447
Signed-off-by: Niels de Vos <ndevos at redhat.com>
Reviewed-on: https://review.gluster.org/17743
Smoke: Gluster Build System <jenkins at build.gluster.org>
Reviewed-by: Milind Changire <mchangir at redhat.com>
CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0gXKyjrtoH&a=cc_unsubscribe
More information about the Bugs
mailing list