[Bugs] [Bug 1487036] New: rpc: client_t and related objects leaked due to incorrect ref counts

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1487036

            Bug ID: 1487036
           Summary: rpc: client_t and related objects leaked due to
                    incorrect ref counts
           Product: GlusterFS
           Version: 3.11
         Component: rpc
          Assignee: bugs at gluster.org
          Reporter: mchangir at redhat.com
                CC: bugs at gluster.org, moagrawa at redhat.com
        Depends On: 1481600



+++ This bug was initially created as a clone of Bug #1481600 +++

Description of problem:
Problem:
1. incorrectly placed gf_client_get() in rpc_request_init()
   gf_client_ref() in rpc_request_init() should be moved to 
   get_frame_from_request()

2. incorrect ref handling in server_rpc_notify() and grace_time_handler()
   2.1 last ref count on client_t should be dropped in 
       RPCSVC_EVENT_TRANSPORT_DESTROY only for non-grace-time-handling case
   2.2 ref should be taken on client_t before being delegated to 
       grace_tim_handler()
   2.3 ref should be dropped from client_t in server_setvolume() when the 
       grace_time_handler() is successfully canceled for a re-connected client

Version-Release number of selected component (if applicable):


How reproducible:
always (with valgrind)

--- Additional comment from Worker Ant on 2017-08-16 19:38:37 IST ---

REVIEW: https://review.gluster.org/17982 (rpc: destroy transport after
client_t) posted (#9) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2017-08-22 15:48:15 IST ---

REVIEW: https://review.gluster.org/17982 (rpc: destroy transport after
client_t) posted (#10) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2017-08-22 15:52:15 IST ---

REVIEW: https://review.gluster.org/17982 (rpc: destroy transport after
client_t) posted (#11) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2017-08-22 15:53:30 IST ---

REVIEW: https://review.gluster.org/17982 (rpc: destroy transport after
client_t) posted (#12) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2017-08-30 08:53:20 IST ---

REVIEW: https://review.gluster.org/17982 (rpc: destroy transport after
client_t) posted (#13) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2017-08-30 08:56:32 IST ---

REVIEW: https://review.gluster.org/17982 (rpc: destroy transport after
client_t) posted (#14) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2017-08-30 09:01:12 IST ---

REVIEW: https://review.gluster.org/17982 (rpc: destroy transport after
client_t) posted (#15) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2017-08-30 11:22:37 IST ---

REVIEW: https://review.gluster.org/17982 (rpc: destroy transport after
client_t) posted (#16) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2017-08-30 11:26:02 IST ---

REVIEW: https://review.gluster.org/17982 (rpc: destroy transport after
client_t) posted (#17) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2017-08-31 09:15:13 IST ---

COMMIT: https://review.gluster.org/17982 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit 24b95089a18a6a40e7703cb344e92025d67f3086
Author: Milind Changire <mchangir at redhat.com>
Date:   Wed Aug 30 11:25:29 2017 +0530

    rpc: destroy transport after client_t

    Problem:
    1. Ref counting increment on the client_t object is done in
       rpcsvc_request_init() which is incorrect.
    2. Ref not taken when delegating to grace_time_handler()

    Solution:
    1. Only fop requests which require processing down the graph via
       stack 'frames' now ref count the request in get_frame_from_request()
    2. Take ref on client_t object in server_rpc_notify() but avoid
       dropping in RPCSVC_EVENT_TRANSPORT_DESRTROY. Drop the ref
       unconditionally when exiting out of grace_time_handler().
       Also, avoid dropping ref on client_t in
       RPCSVC_EVENT_TRANSPORT_DESTROY when ref mangement as been
       delegated to grace_time_handler()

    Change-Id: Ic16246bebc7ea4490545b26564658f4b081675e4
    BUG: 1481600
    Reported-by: Raghavendra G <rgowdapp at redhat.com>
    Signed-off-by: Milind Changire <mchangir at redhat.com>
    Reviewed-on: https://review.gluster.org/17982
    Tested-by: Raghavendra G <rgowdapp at redhat.com>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>

--- Additional comment from Milind Changire on 2017-08-31 11:29:16 IST ---

Correction to the problem description:

Description of problem:
Problem:
1. incorrectly placed gf_client_get() in rpc_request_init()
   gf_client_ref() in rpc_request_init() should be moved to 
   get_frame_from_request()

2. incorrect ref handling in server_rpc_notify() and grace_time_handler()
   2.1 last ref count on client_t should be dropped in 
       RPCSVC_EVENT_TRANSPORT_DESTROY only for non-grace-time-handling case
   2.2 ref should be taken on client_t before being delegated to 
       grace_tim_handler()
   2.3 ref should be dropped from client_t in server_setvolume() when the 
       grace_time_handler() is successfully canceled for a re-connected client


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1481600
[Bug 1481600] rpc: client_t and related objects leaked due to incorrect ref
counts
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.