[Bugs] [Bug 1481600] rpc: client_t and related objects leaked due to incorrect ref counts

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1481600



--- Comment #10 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17982 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit 24b95089a18a6a40e7703cb344e92025d67f3086
Author: Milind Changire <mchangir at redhat.com>
Date:   Wed Aug 30 11:25:29 2017 +0530

    rpc: destroy transport after client_t

    Problem:
    1. Ref counting increment on the client_t object is done in
       rpcsvc_request_init() which is incorrect.
    2. Ref not taken when delegating to grace_time_handler()

    Solution:
    1. Only fop requests which require processing down the graph via
       stack 'frames' now ref count the request in get_frame_from_request()
    2. Take ref on client_t object in server_rpc_notify() but avoid
       dropping in RPCSVC_EVENT_TRANSPORT_DESRTROY. Drop the ref
       unconditionally when exiting out of grace_time_handler().
       Also, avoid dropping ref on client_t in
       RPCSVC_EVENT_TRANSPORT_DESTROY when ref mangement as been
       delegated to grace_time_handler()

    Change-Id: Ic16246bebc7ea4490545b26564658f4b081675e4
    BUG: 1481600
    Reported-by: Raghavendra G <rgowdapp at redhat.com>
    Signed-off-by: Milind Changire <mchangir at redhat.com>
    Reviewed-on: https://review.gluster.org/17982
    Tested-by: Raghavendra G <rgowdapp at redhat.com>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XVIaS6OhZE&a=cc_unsubscribe