[Bugs] [Bug 1486120] symlinks trigger faulty geo-replication state ( rsnapshot usecase)

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1486120



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/18127 committed in release-3.12 by
Shyamsundar Ranganathan (srangana at redhat.com) 
------
commit b04b3dd4dc8fcff9ad44e31d1da810eba223cd08
Author: Kotresh HR <khiremat at redhat.com>
Date:   Tue Aug 8 10:12:14 2017 -0400

    geo-rep: Fix syncing of hardlink of symlink

    Problem:
    If there is a hardlink to a symlink on master
    and if the symlink file is deleted on master,
    geo-rep fails to sync the hardlink.

    Typical Usecase:
    It's easily hit with rsnapshot use case where
    it uses hardlinks.

    Example Reproducer:
    Setup geo-replication between master and slave
    volume and in master mount point, do the following.

     1. mkdir /tmp/symlinkbug
     2. ln -f -s /does/not/exist /tmp/symlinkbug/a_symlink
     3. rsync -a /tmp/symlinkbug ./
     4. cp -al symlinkbug symlinkbug.0
     5. ln -f -s /does/not/exist2 /tmp/symlinkbug/a_symlink
     6. rsync -a /tmp/symlinkbug ./
     7. cp -al symlinkbug symlinkbug.1

    Cause:
    If the source was not present while syncing hardlink,
    it was always packing the blob as regular file.

    Fix:
    If the source was not present while syncing hardlink,
    pack the blob based on the mode.

    > Change-Id: Iaa12d6f99de47b18e0650e7c4eb455f23f8390f2
    > BUG: 1432046
    > Signed-off-by: Kotresh HR <khiremat at redhat.com>
    > Reported-by: Christian Lohmaier <lohmaier+rhbz at gmail.com>
    > Reviewed-on: https://review.gluster.org/18011
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Aravinda VK <avishwan at redhat.com>
    (cherry picked from commit e893962deaabab8e934813f8a0443a8f94e009f2)

    Change-Id: Iaa12d6f99de47b18e0650e7c4eb455f23f8390f2
    BUG: 1486120
    Signed-off-by: Kotresh HR <khiremat at redhat.com>
    Reviewed-on: https://review.gluster.org/18127
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SMPxL2BC9F&a=cc_unsubscribe