[Bugs] [Bug 1484246] New: [PATCH] incorrect xattr list handling on FreeBSD

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1484246

            Bug ID: 1484246
           Summary: [PATCH] incorrect xattr list handling on FreeBSD
           Product: GlusterFS
           Version: mainline
         Component: posix
          Assignee: nfsmwlin at gmail.com
          Reporter: jthottan at redhat.com
                CC: bugs at gluster.org, iblis at hs.ntnu.edu.tw,
                    nfsmwlin at gmail.com, pkarampu at redhat.com
            Blocks: 1452961



+++ This bug was initially created as a clone of Bug #1452961 +++

Description of problem:
The Linux llistxattr() system call and the FreeBSD extattr_list_link() system
call    both get the list of xattrs, but in different format (check the
manpages):

Linux: attr<\0>attr<\0>
FreeBSD: <attr_len>attr<attr_len>attr

But in the caller sys_llistxattr and sys_flistxattr do not take the format
difference into account.

This patch is based on v3.9.0, it fixes the problem by introducing a new
function extattr_list_reshape to reshape the FreeBSD list format into Linux's.

This patch is authored by Iblis Lin <iblis at hs.ntnu.edu.tw> and tested by
Pellaeon Lin <pellaeon at cnmc.tw>

For your reference, here's the Gist comparing GDB output of volume process with
and without patch:
https://gist.github.com/pellaeon/bfa9b094e11b47a88bf51f5aa73b9a6d

--- Additional comment from  on 2017-05-21 05:12:02 EDT ---

This patch fixes the problem described by:
https://bugzilla.redhat.com/show_bug.cgi?id=1181500#c5

But I'm not sure it'll solve the bug 1181500 .

--- Additional comment from Pranith Kumar K on 2017-07-12 23:00:01 EDT ---

(In reply to nfsmwlin from comment #1)
> This patch fixes the problem described by:
> https://bugzilla.redhat.com/show_bug.cgi?id=1181500#c5
> 
> But I'm not sure it'll solve the bug 1181500 .

hey, this is good patch. Do you want to send the patch on review.gluster.org?


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1452961
[Bug 1452961] [PATCH] incorrect xattr list handling on FreeBSD
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ChNkQ21zmX&a=cc_unsubscribe