[Bugs] [Bug 1479474] New: Add NULL gfid checks before creating file

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1479474

            Bug ID: 1479474
           Summary: Add NULL gfid checks before creating file
           Product: GlusterFS
           Version: 3.12
         Component: posix
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ravishankar at redhat.com
                CC: bugs at gluster.org
        Depends On: 1478297



+++ This bug was initially created as a clone of Bug #1478297 +++

Description of problem:
Add checks in code to prevent file potentially being created with a gfid of all
zeroes.

--- Additional comment from Worker Ant on 2017-08-04 04:40:51 EDT ---

REVIEW: https://review.gluster.org/17975 (posix: add null gfid checks) posted
(#1) for review on master by Ravishankar N (ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-08-05 03:59:24 EDT ---

REVIEW: https://review.gluster.org/17981 (afr: Prevent null gfids in self-heal
entry re-creation) posted (#1) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-08-05 04:21:56 EDT ---

REVIEW: https://review.gluster.org/17975 (posix: add null gfid checks) posted
(#2) for review on master by Ravishankar N (ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-08-07 04:55:36 EDT ---

REVIEW: https://review.gluster.org/17975 (posix: add null gfid checks) posted
(#3) for review on master by Ravishankar N (ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-08-07 23:37:05 EDT ---

COMMIT: https://review.gluster.org/17981 committed in master by Ravishankar N
(ravishankar at redhat.com) 
------
commit bead74a6e085001225bc0704bad1a5db36dd75a1
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Fri Aug 4 16:23:46 2017 +0530

    afr: Prevent null gfids in self-heal entry re-creation

    Change-Id: I5acb8bd0a19fc4e764d61e349bb690b5236ee610
    BUG: 1478297
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: https://review.gluster.org/17981
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Amar Tumballi <amarts at redhat.com>
    Reviewed-by: Karthik U S <ksubrahm at redhat.com>

--- Additional comment from Worker Ant on 2017-08-08 08:54:29 EDT ---

COMMIT: https://review.gluster.org/17975 committed in master by Raghavendra
Bhat (raghavendra at redhat.com) 
------
commit c63aa2239bc682739328e0aa6cbcb3279a72a8e2
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Mon Aug 7 12:14:23 2017 +0530

    posix: add null gfid checks

    ...in file/dir creation and lookup codepaths. The check is relaxed for
    fops coming from trash xlator at the moment until trash has client side
    logic to send the create fops with gfid-req.

    Also fixed the missing trash pid assignment in creates sent by trash
    xlator. Without this, truncated files won't be moved to .trashcan.

    Change-Id: Ieddd7f0634850e7c7010e4fbb4ad1eead35888c8
    BUG: 1478297
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: https://review.gluster.org/17975
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra Bhat <raghavendra at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1478297
[Bug 1478297] Add NULL gfid checks before creating file
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.